Skip to content

GetSharesByNamespace JSON RPC returns the the old representation of NamespacedShares #2631

@oblique

Description

@oblique

Celestia Node version

4b96022

OS

Arch Linux

Install tools

No response

Others

No response

Steps to reproduce it

Do share.GetSharesByNamespace request.

Expected result

I was expecting to get the new protobuf representation (share.p2p.shrex.nd.NamespaceRowResponse):

[
    {
      "shares": [],
      "proof": {
        "start": 1,
        "end": 2,
        "nodes": [
          "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABEinncqCRtmn9rQpzZu1bRShpoTh01mE75gkp9C68byu",
          "/////////////////////////////////////////////////////////////////////////////w81Htmj5E2p0vlhWgUHbEu+jHu0S74GbTWrHUPWC0NB"
        ],
        "leafHash": "AAAAAAAAAAAAAAAAAAAAAAAAAAwECTkh44s4pzQAAAAAAAAAAAAAAAAAAAAAAAAADAQJOSHjizinNErclwFCmkujstcQOiIunyB5edz+oREPWyE1GeDzvN9+",
        "isMaxNamespaceIgnored": true
      }
    }
]

Actual result

Instead I got the old representation (share.NamespacedShares):

[
    {
      "Shares": [],
      "Proof": {
        "start": 1,
        "end": 2,
        "nodes": [
          "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABEinncqCRtmn9rQpzZu1bRShpoTh01mE75gkp9C68byu",
          "/////////////////////////////////////////////////////////////////////////////w81Htmj5E2p0vlhWgUHbEu+jHu0S74GbTWrHUPWC0NB"
        ],
        "leaf_hash": "AAAAAAAAAAAAAAAAAAAAAAAAAAwECTkh44s4pzQAAAAAAAAAAAAAAAAAAAAAAAAADAQJOSHjizinNErclwFCmkujstcQOiIunyB5edz+oREPWyE1GeDzvN9+",
        "is_max_namespace_id_ignored": true
      }
    }
]

Relevant log output

No response

Notes

I think the issue starts from here.

Metadata

Metadata

Labels

bugSomething isn't workingexternalIssues created by non node team members

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions