Merged
Conversation
4 tasks
liamsi
reviewed
Aug 25, 2021
Member
liamsi
left a comment
There was a problem hiding this comment.
Notably retains #400 and keeps the embedded node option in the light client.
We should probably remove the changes to the light client here as well. As the DAS light client logic will also be moved into the Celestia-node. No need to change this in this PR though.
Closed
12 tasks
evan-forbes
pushed a commit
that referenced
this pull request
Mar 11, 2025
…espect coherence all over our code (#514) * Review and fix propoal coherence in all applications in the code base * Fixed comment for Commit --------- Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR stops embedding an IPFS node in celestia-core. Notably retains #400 and keeps the embedded node option in the light client.
should be merged either into or after #510
can be merged before or after #508
part of #506