Stop Signing over the PartSetHeader for Votes and remove it from the Header#457
Merged
evan-forbes merged 16 commits intomasterfrom Jul 27, 2021
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR builds off of #441 and continues the work of #418 by not including the
PartSetHeaderin theCanonicalVote. It also removes thePartSetHeaderfrom theHeader's hash by removing it entirely from bothtypes.Headerandtmproto.HeaderThis PR can be merged into #441 or master after #441 is merged, whichever is most convenient for the reviewers
Closes: #456