build(deps): Bump github.com/spf13/cobra from 1.1.1 to 1.1.3#161
Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
Closed
build(deps): Bump github.com/spf13/cobra from 1.1.1 to 1.1.3#161dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.1.1 to 1.1.3. - [Release notes](https://github.com/spf13/cobra/releases) - [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md) - [Commits](spf13/cobra@v1.1.1...v1.1.3) Signed-off-by: dependabot[bot] <support@github.com>
Contributor
Author
|
Dependabot tried to add |
Member
|
The SDK up to version 0.41.x still uses cobra 1.1.1. Closing this as I'd like to keep version parity between ll-core and the latest SDK for now. |
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
evan-forbes
pushed a commit
that referenced
this pull request
Mar 11, 2025
Follow-up to #137. Fixes the Docker builds that were failing to be parsed by GitHub Actions. Also fixes our `make build-docker` target to build images in the same way we do in CI. On Linux, I have to explicitly tell Docker to use BuildKit to pass the target/build platform args in: ```bash DOCKER_BUILDKIT=1 make build-docker ``` Given that I've also proven now that the images do build in CI (see [this workflow](https://github.com/cometbft/cometbft/actions/runs/3964436268/jobs/6793294390) and [this one](https://github.com/cometbft/cometbft/actions/runs/3964436273/jobs/6793294238)), we no longer need to build on every change to every pull request. The E2E node Docker image in particular takes nearly 30mins to build, so that would slow us down tremendously. It's far better to build those images only once PRs get merged. --- #### PR checklist - [x] Tests written/updated, or no tests needed - [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed - [x] Updated relevant documentation (`docs/`) and code comments, or no documentation updates needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/spf13/cobra from 1.1.1 to 1.1.3.
Release notes
Sourced from github.com/spf13/cobra's releases.
Changelog
Sourced from github.com/spf13/cobra's changelog.
Commits
8380dddFix typo43d0bfcUpdate CHANGELOG.md for v1.1.3db3e175Revert "Deprecate Go < 1.14 (#1323)" to maintain v1.1 branch compatibility7f95502Update CHANGELOG.md for v1.1.207445eaCopyedit shell-completion related documentationb73b344ci: add GitHub Actions workflow 'Test' (#1339)652c755Use golangci-lint (#1044)1d71ff0Deprecate Go < 1.14 (#1323)1135bdeUpdate gopkg.in/yaml.v2 to v2.4.09df156eCobra User Contract (#1292)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)