crypto/secp256k1: fix .String()#137
Merged
liamsi merged 1 commit intocelestiaorg:masterfrom Jan 12, 2021
tac0turtle:secp-string
Merged
crypto/secp256k1: fix .String()#137liamsi merged 1 commit intocelestiaorg:masterfrom tac0turtle:secp-string
liamsi merged 1 commit intocelestiaorg:masterfrom
tac0turtle:secp-string
Conversation
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 60.33% 60.84% +0.50%
==========================================
Files 262 261 -1
Lines 23888 23642 -246
==========================================
- Hits 14414 14384 -30
+ Misses 7979 7766 -213
+ Partials 1495 1492 -3
|
liamsi
approved these changes
Jan 12, 2021
Member
There was a problem hiding this comment.
Saw the fix in tendermint a while ago. Was a bit surprised that slicing causes the stack to overflow tbh.
(ref: tendermint/tendermint#5707)
LGTM
evan-forbes
pushed a commit
that referenced
this pull request
Mar 11, 2025
* Replace tm-db with cometbft-db Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Update build workflow to use private cometbft-db repo Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Build Docker image on PRs to ensure this works Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Enable private module access for E2E workflows Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Enable private module access for mock generation check Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Enable private module access for tests Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Cosmetic update to build workflow Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Enable private module access for vulncheck Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Enable private module access for linter Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Build Docker image on PRs to ensure this works Signed-off-by: Thane Thomson <connect@thanethomson.com> * docker: Add support for usage of cometbft-db as private module Signed-off-by: Thane Thomson <connect@thanethomson.com> * Replace TENDERMINT_BUILD_OPTIONS with COMETBFT_BUILD_OPTIONS to fix building of database support Signed-off-by: Thane Thomson <connect@thanethomson.com> * deps: Update cometbft-db to latest unreleased commit Signed-off-by: Thane Thomson <connect@thanethomson.com> * deps: Update cometbft-db to latest unreleased commit Signed-off-by: Thane Thomson <connect@thanethomson.com> * Bump cometbft-db version to v0.7.0 Signed-off-by: Thane Thomson <connect@thanethomson.com> * Minor formatting fixes Signed-off-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: Thane Thomson <connect@thanethomson.com>
evan-forbes
pushed a commit
that referenced
this pull request
Mar 11, 2025
Follow-up to #137. Fixes the Docker builds that were failing to be parsed by GitHub Actions. Also fixes our `make build-docker` target to build images in the same way we do in CI. On Linux, I have to explicitly tell Docker to use BuildKit to pass the target/build platform args in: ```bash DOCKER_BUILDKIT=1 make build-docker ``` Given that I've also proven now that the images do build in CI (see [this workflow](https://github.com/cometbft/cometbft/actions/runs/3964436268/jobs/6793294390) and [this one](https://github.com/cometbft/cometbft/actions/runs/3964436273/jobs/6793294238)), we no longer need to build on every change to every pull request. The E2E node Docker image in particular takes nearly 30mins to build, so that would slow us down tremendously. It's far better to build those images only once PRs get merged. --- #### PR checklist - [x] Tests written/updated, or no tests needed - [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed - [x] Updated relevant documentation (`docs/`) and code comments, or no documentation updates needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is already in Tendermint just hasn't been added to LL