Reverted unwanted constraint introduced in #1629 with max_retries#1755
Merged
auvipy merged 1 commit intocelery:mainfrom Jun 19, 2023
Merged
Reverted unwanted constraint introduced in #1629 with max_retries#1755auvipy merged 1 commit intocelery:mainfrom
auvipy merged 1 commit intocelery:mainfrom
Conversation
…es not being able to be None (when it should)
auvipy
approved these changes
Jun 19, 2023
Member
auvipy
left a comment
There was a problem hiding this comment.
OK thanks for the partial revert. I hope to get chance to review all big PR O:)
Nusnus
added a commit
to Katz-Consulting-Group/kombu
that referenced
this pull request
Jun 20, 2023
Nusnus
added a commit
that referenced
this pull request
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1629 introduced a constraint forcing setting
max_retrieswhen it was originally designed to be able to beNonefor infinite retries.This PR relaxes back the constraint as it was before while keeping the change from #1629