Skip to content

Allowing Connection.ensure() to retry on specific exceptions given by policy#1629

Merged
thedrow merged 3 commits intocelery:masterfrom
Katz-Consulting-Group:blm-145
Dec 18, 2022
Merged

Allowing Connection.ensure() to retry on specific exceptions given by policy#1629
thedrow merged 3 commits intocelery:masterfrom
Katz-Consulting-Group:blm-145

Conversation

@Nusnus
Copy link
Copy Markdown
Member

@Nusnus Nusnus commented Dec 15, 2022

To be used with task_publish_retry_policy

@Nusnus Nusnus added this to the 5.3 milestone Dec 15, 2022
@Nusnus Nusnus self-assigned this Dec 15, 2022
@Nusnus Nusnus requested a review from auvipy December 15, 2022 15:09
@Nusnus
Copy link
Copy Markdown
Member Author

Nusnus commented Dec 15, 2022

The PR is in draft because I want to make some manual tests first for this change, if they passes I'll move this to "Ready for Review"

@Nusnus
Copy link
Copy Markdown
Member Author

Nusnus commented Dec 15, 2022

@auvipy Do we have any lead on the redis auth errors?

@auvipy
Copy link
Copy Markdown
Member

auvipy commented Dec 15, 2022

that might be for new redis server / library release issue. have to check. allow me till saturday. I have to adjust/update CI of both kombu and py-amqp and packaging

@Nusnus
Copy link
Copy Markdown
Member Author

Nusnus commented Dec 15, 2022

Yeah I noticed the update to redis. Thanks for taking care of that!

@Nusnus Nusnus marked this pull request as ready for review December 18, 2022 10:31
@thedrow thedrow merged commit 44025bf into celery:master Dec 18, 2022
Nusnus added a commit to Katz-Consulting-Group/kombu that referenced this pull request Jun 18, 2023
…es not being able to be None (when it should)
auvipy pushed a commit that referenced this pull request Jun 19, 2023
@auvipy
Copy link
Copy Markdown
Member

auvipy commented Aug 15, 2023

It was eventually reverted

@auvipy auvipy modified the milestones: 5.3, 5.3.x Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants