remove importlib-metadata as not needed in python3.8 anymore #9612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9612 +/- ##
=======================================
Coverage 78.30% 78.31%
=======================================
Files 153 153
Lines 19112 19112
Branches 2530 2530
=======================================
+ Hits 14966 14967 +1
+ Misses 3859 3857 -2
- Partials 287 288 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cjwatson
added a commit
to cjwatson/celery
that referenced
this pull request
Jul 3, 2025
Celery's use of `importlib_metadata` was removed in celery#9612 (since Celery now requires Python 3.8 which contains `importlib.metadata` in the standard library), but a few conditional imports were left behind.
auvipy
added a commit
that referenced
this pull request
Jul 7, 2025
Celery's use of `importlib_metadata` was removed in #9612 (since Celery now requires Python 3.8 which contains `importlib.metadata` in the standard library), but a few conditional imports were left behind. Co-authored-by: Asif Saif Uddin <auvipy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is there anywhere else we need to remove this?