Skip to content

Conversation

@cjwatson
Copy link
Contributor

@cjwatson cjwatson commented Jul 3, 2025

Description

Celery's use of importlib_metadata was removed in #9612 (since Celery now requires Python 3.8+ which contains importlib.metadata in the standard library), but a few conditional imports were left behind.

Celery's use of `importlib_metadata` was removed in celery#9612 (since Celery
now requires Python 3.8 which contains `importlib.metadata` in the
standard library), but a few conditional imports were left behind.
@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.62%. Comparing base (4c7443d) to head (86e522f).
⚠️ Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
celery/utils/imports.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9791   +/-   ##
=======================================
  Coverage   78.62%   78.62%           
=======================================
  Files         153      153           
  Lines       19201    19199    -2     
  Branches     2547     2547           
=======================================
  Hits        15096    15096           
+ Misses       3812     3811    -1     
+ Partials      293      292    -1     
Flag Coverage Δ
unittests 78.60% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auvipy auvipy self-requested a review July 3, 2025 13:57
@auvipy auvipy added this to the 5.6.0 milestone Jul 3, 2025
@auvipy auvipy merged commit 1b2583e into celery:main Jul 7, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants