Fix eager tasks does not populate name field#8383
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8383 +/- ##
=======================================
Coverage 87.07% 87.07%
=======================================
Files 148 148
Lines 18491 18492 +1
Branches 3152 3152
=======================================
+ Hits 16101 16102 +1
Misses 2110 2110
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
auvipy
left a comment
There was a problem hiding this comment.
that looks good to me! can we add some sort of integration test for this as well? some manual acknowledgement would be also great
|
Thank you @auvipy! I took a look at the existing tests but I didn't find any for similar case so I'm not sure what type of test can we provide for this. If you can show me some which you think can be used as starter and specify what you think should be tested, I'm happy to write some. |
|
I think we are safe to go as is for now |
|
can you release a version ? |
|
it will be included in next point release very soon |
|
we got a bug / regression report here #8472 can you please verify? |
Note: Before submitting this pull request, please review our contributing guidelines.
Description
Multiple issues were reported both here (#7715) and in django-celery-results (celery/django-celery-results#289 & celery/django-celery-results#362) that when running in eager mode name of the tasks are not populated. After my investigation it seems to me that this field was just missed as it's not critical in terms of functionality. I added it and it seems to work.
Let me know what do you think.
Fixes #7715