Revert "Fix eager tasks does not populate name field"#8476
Merged
Conversation
This reverts commit 1c36387.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8476 +/- ##
==========================================
- Coverage 87.44% 87.43% -0.01%
==========================================
Files 148 148
Lines 18488 18487 -1
Branches 3155 3155
==========================================
- Hits 16166 16165 -1
Misses 2033 2033
Partials 289 289
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Member
Author
|
but if you have a better solution in mind other then reverting, feel free to share. |
Member
Nothing at the moment. I'll give it another look after we finish stabilize the codebase and release a new patch version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8383
@Nusnus might be another potential one. unless we got a suitable solution or a non breaking change, we can defer this to v5.4.0