Skip to content

feat(tokens): update color tokens pt3#8376

Merged
kodiakhq[bot] merged 13 commits into
carbon-design-system:mainfrom
tw15egan:token-update-pt3
Apr 23, 2021
Merged

feat(tokens): update color tokens pt3#8376
kodiakhq[bot] merged 13 commits into
carbon-design-system:mainfrom
tw15egan:token-update-pt3

Conversation

@tw15egan

@tw15egan tw15egan commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

Closes #8303

Components to be updated:

  • Tag
  • Textarea
  • TextInput
  • Tile
  • TimePicker
  • Toggle
  • Tooltip
  • Treeview
  • UI Shell (replace old color tokens, old UI Shell tokens will be updated in a separate PR)

We will also need to update all global scss files to reference new color tokens

  • globals/scss

Changelog

Changed

  • Old color tokens replaced with new ones

Removed

  • Some duplicate selectors we refactored to one selector

Testing / Reviewing

Go over the list above and ensure all components look correct

@tw15egan tw15egan changed the title Token update pt3 feat(tokens): Update color tokens pt3 Apr 12, 2021
@tw15egan tw15egan changed the title feat(tokens): Update color tokens pt3 feat(tokens): update color tokens pt3 Apr 12, 2021
@netlify

netlify Bot commented Apr 12, 2021

Copy link
Copy Markdown

Deploy preview for carbon-elements failed.

Built with commit 8d3ac25

https://app.netlify.com/sites/carbon-elements/deploys/6082be1317543c0008386b4a

@netlify

netlify Bot commented Apr 12, 2021

Copy link
Copy Markdown

Comment thread packages/components/src/components/data-table/_data-table-core.scss Outdated
@tw15egan tw15egan marked this pull request as ready for review April 13, 2021 23:15
@tw15egan tw15egan requested a review from a team as a code owner April 13, 2021 23:15
@tw15egan tw15egan requested review from emyarod and jnm2377 April 13, 2021 23:15
@tw15egan tw15egan requested a review from aagonzales April 13, 2021 23:15
Comment thread packages/components/src/components/toggle/_toggle.scss Outdated
Comment thread packages/components/src/components/data-table/_data-table-core.scss Outdated
Comment thread packages/components/src/components/data-table/_data-table-core.scss Outdated
@tw15egan

Copy link
Copy Markdown
Contributor Author

@aagonzales just pushed up some changes 👍🏻

@emyarod emyarod requested a review from aagonzales April 15, 2021 14:55
@kodiakhq kodiakhq Bot merged commit 3804612 into carbon-design-system:main Apr 23, 2021
Comment thread packages/components/src/components/ui-shell/_content.scss
joshblack added a commit to joshblack/carbon that referenced this pull request Jun 29, 2021
kodiakhq Bot added a commit that referenced this pull request Jul 1, 2021
This reverts commit 3804612.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: TJ Egan <tw15egan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update 25% of components to use new design tokens (4/4)

6 participants