Skip to content

Revert "feat(tokens): update color tokens pt3 (#8376)"#9067

Merged
kodiakhq[bot] merged 5 commits into
carbon-design-system:mainfrom
joshblack:revert/color-token-refactor-part-four
Jul 1, 2021
Merged

Revert "feat(tokens): update color tokens pt3 (#8376)"#9067
kodiakhq[bot] merged 5 commits into
carbon-design-system:mainfrom
joshblack:revert/color-token-refactor-part-four

Conversation

@joshblack

@joshblack joshblack commented Jun 29, 2021

Copy link
Copy Markdown
Contributor

This reverts commit 3804612.

We've run into several challenges with our tokens being used in our components without a feature toggle 😞 This PR is our first attempt at reverting this behavior so that teams can safely update.

Components impacted:

  • Tag
  • Textarea
  • TextInput
  • Tile
  • TimePicker
  • Toggle
  • Tooltip
  • Treeview
  • UI Shell

Changelog

New

Changed

  • Revert token changes

Removed

Testing / Reviewing

Verify components above render as expected in the netlify preview and no new tokens exist in the stylesheets

@joshblack joshblack requested a review from a team as a code owner June 29, 2021 21:24
@joshblack joshblack requested review from emyarod and jnm2377 June 29, 2021 21:24
@netlify

netlify Bot commented Jun 29, 2021 •
edited
Loading

Copy link
Copy Markdown

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: d176677

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60de35055021970007e86548

@netlify

netlify Bot commented Jun 29, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d176677

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60de3505dd295a000788db31

😎 Browse the preview: https://deploy-preview-9067--carbon-elements.netlify.app

@netlify

netlify Bot commented Jun 29, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: d176677

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60de3505faad00000825d42b

😎 Browse the preview: https://deploy-preview-9067--carbon-components-react.netlify.app

@jnm2377

jnm2377 commented Jun 30, 2021

Copy link
Copy Markdown
Contributor

😭

@kodiakhq kodiakhq Bot merged commit ff0c568 into carbon-design-system:main Jul 1, 2021
@tw15egan tw15egan mentioned this pull request Jul 12, 2021
Closed
@chriswatrous chriswatrous mentioned this pull request Aug 16, 2021
Closed
2 tasks
@tw15egan tw15egan mentioned this pull request Aug 17, 2021
Merged
@jnm2377 jnm2377 mentioned this pull request Nov 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emyarod emyarod emyarod approved these changes

+1 more reviewer

@jnm2377 jnm2377 jnm2377 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshblack @jnm2377 @emyarod @tw15egan