fix(interior-left-nav): added dynamic svg title#319
Merged
marijohannessen merged 5 commits intoOct 2, 2017
Merged
Conversation
Contributor
|
👍 ✅ |
asudoh
suggested changes
Sep 27, 2017
| this.element.dataset.collapsed = true; | ||
| this.element.classList.add(this.options.classLeftNavCollapsing); | ||
|
|
||
| svgTitle.innerHTML = 'Expand nav pane'; |
Contributor
There was a problem hiding this comment.
Two things here and https://github.com/carbon-design-system/carbon-components/pull/319/files#diff-2e7e5be2ee91d6de1c6604f6fa89bbf5R186:
- I’d suggest
.textContentinstead of.innerHTML- The latter triggers HTML parser - i18n - I’d suggest putting the text to static
options.expandTitleproperty and then make this line refer tothis.options.expandTitle(Note that all staticoptionswork as default values for instanceoptions)
| selectorLeftNavListItemHasChildren: | ||
| '[data-interior-left-nav-with-children]', | ||
| selectorLeftNavCollapse: '[data-interior-left-nav-collapse]', | ||
| selectorLeftNavArrow: '[data-interior-left-nav-arrow]', |
Contributor
There was a problem hiding this comment.
Probably we’d make it [data-interior-left-nav-arrow] title (and rename this property to selectorLeftNavArrowTitle). In this way, we can consolidate two qSA calls to one.
asudoh
approved these changes
Sep 28, 2017
asudoh
left a comment
Contributor
There was a problem hiding this comment.
Thank you for making an update! Seems that the new commit marked my other comments stale - Bringing them back.
| this.element.dataset.collapsed = true; | ||
| this.element.classList.add(this.options.classLeftNavCollapsing); | ||
|
|
||
| svgTitle.textContent = 'Expand nav pane'; |
| this.element.classList.remove(this.options.classLeftNavCollapsed); | ||
| this.element.classList.add(this.options.classLeftNavExpanding); | ||
|
|
||
| svgTitle.textContent = 'Collapse nav pane'; |
| '[data-interior-left-nav-with-children]', | ||
| selectorLeftNavListItemHasChildren: '[data-interior-left-nav-with-children]', | ||
| selectorLeftNavCollapse: '[data-interior-left-nav-collapse]', | ||
| selectorLeftNavArrow: '[data-interior-left-nav-arrow]', |
Contributor
Author
|
Yeah I didn't have time to get to it yesterday, sorry about that! I've addressed all your comments now @asudoh 😄 |
asudoh
approved these changes
Sep 29, 2017
asudoh
left a comment
Contributor
There was a problem hiding this comment.
Great thank you for making the changes @marijohannessen!
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
* docs: add CRA example * chore: add examples dir ot testPathIgnorePatterns
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 8, 2019
paul-palade
added a commit
to paul-palade/carbon
that referenced
this pull request
May 21, 2026
Submitting 14 new pictograms from June 2026 and updated categories. Updated master file. All additions and updates approved by BXD. Addressing issues carbon-design-system#319, carbon-design-system#321, carbon-design-system#324 and carbon-design-system#325 in brand/pictograms. ### Changelog **New** `Cities` - [x] chennai.svg - [x] denver.svg - [x] frankfurt.svg - [x] los-angeles.svg - [x] miami.svg - [x] oslo.svg - [x] perth.svg - [x] san-jose.svg - [x] taipei.svg `Design and development` - [x] technology-zone--finger.svg `Electronics` - [x] laptop.svg `Lifestyle` - [x] lotus--flower.svg `Workplace` - [x] men--showers.svg - [x] women--showers.svg **Updated** `Lifestyle` - half-note.svg - hard--ice--cream.svg Updated alphabetical order in categories.yml
adamalston
pushed a commit
to adamalston/carbon
that referenced
this pull request
May 26, 2026
* feat(pictograms): new Pictograms June 2026 Submitting 14 new pictograms from June 2026 and updated categories. Updated master file. All additions and updates approved by BXD. Addressing issues carbon-design-system#319, carbon-design-system#321, carbon-design-system#324 and carbon-design-system#325 in brand/pictograms. ### Changelog **New** `Cities` - [x] chennai.svg - [x] denver.svg - [x] frankfurt.svg - [x] los-angeles.svg - [x] miami.svg - [x] oslo.svg - [x] perth.svg - [x] san-jose.svg - [x] taipei.svg `Design and development` - [x] technology-zone--finger.svg `Electronics` - [x] laptop.svg `Lifestyle` - [x] lotus--flower.svg `Workplace` - [x] men--showers.svg - [x] women--showers.svg **Updated** `Lifestyle` - half-note.svg - hard--ice--cream.svg Updated alphabetical order in categories.yml * Update packages/pictograms/pictograms.yml Resolved two instances of `men--showers` in pictograms.yml Co-authored-by: Mahmoud <132728978+maradwan26@users.noreply.github.com> * chore: update snapshots --------- Co-authored-by: Mahmoud <132728978+maradwan26@users.noreply.github.com> Co-authored-by: Mahmoud <maradwan26@gmail.com>
heloiselui
added a commit
to heloiselui/carbon
that referenced
this pull request
Jun 5, 2026
…22366) * feat(pictograms): new Pictograms June 2026 Submitting 14 new pictograms from June 2026 and updated categories. Updated master file. All additions and updates approved by BXD. Addressing issues carbon-design-system#319, carbon-design-system#321, carbon-design-system#324 and carbon-design-system#325 in brand/pictograms. ### Changelog **New** `Cities` - [x] chennai.svg - [x] denver.svg - [x] frankfurt.svg - [x] los-angeles.svg - [x] miami.svg - [x] oslo.svg - [x] perth.svg - [x] san-jose.svg - [x] taipei.svg `Design and development` - [x] technology-zone--finger.svg `Electronics` - [x] laptop.svg `Lifestyle` - [x] lotus--flower.svg `Workplace` - [x] men--showers.svg - [x] women--showers.svg **Updated** `Lifestyle` - half-note.svg - hard--ice--cream.svg Updated alphabetical order in categories.yml * Update packages/pictograms/pictograms.yml Resolved two instances of `men--showers` in pictograms.yml Co-authored-by: Mahmoud <132728978+maradwan26@users.noreply.github.com> * chore: update snapshots * feat(pictograms): new Pictograms June 2026 (2) Submitting 1 new pictogram from June 2026 and updated categories. Updated master file. All additions and updates approved by BXD. Addressing issue [carbon-design-system#322](https://github.ibm.com/brand/Pictograms/issues/322) in brand/pictograms. ### Changelog **New** `Cities` - [x] ibm--atx-office.svg * chore: update snapshots --------- Co-authored-by: Mahmoud <132728978+maradwan26@users.noreply.github.com> Co-authored-by: Mahmoud <maradwan26@gmail.com> Co-authored-by: Heloise Lui <71858203+heloiselui@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #243
Added dynamic svg title to the collapse arrow.