Document rbenv_ruby_dir option#91
Merged
mattbrictson merged 1 commit intocapistrano:masterfrom May 15, 2020
Merged
Conversation
Hi, I'm using fullstaqruby on a new server (https://github.com/fullstaq-labs/fullstaq-ruby-server-edition), it's an optimized ruby distribution that integrates nicely with rbenv. The only problem I found was when capistrano-rbenv tried to check the versions folder. Checking the code I found that it was possible to change the value of rbenv_ruby_dir and worked great. I've also had to modify the path to the rbenv bin file, but that's more or less documented (modifying the :rbenv_prefix setting), that can probably be documented on the fullstaqruby github readme. If you are ok I think it would be good to document the option, in case someone else find itself in the same position :)
Member
|
Great explanation, thanks for the contribution! |
mattbrictson
pushed a commit
that referenced
this pull request
Jul 10, 2020
Fullstaq Ruby installs Ruby to /usr/lib/fullstaq-ruby/versions (of which /usr/lib/rbenv/versions is a symlink to). The currently documented way to support this is via setting `rbenv_ruby` to /usr/lib/fullstaq-ruby/versions, as implemented in pull request #91. However, the drawback of this approach is that SSHKit command mappings don't work. When one calls... execute(:ruby, '-v') ...capistrano-rbenv ends up executing $HOME/.rbenv/bin/rbenv. But Rbenv is not installed there, but in /usr/lib/rbenv/bin/rbenv. This change adds full support for Fullstaq Ruby, in a way that makes SSHKit command mappings work. Requires Fullstaq Ruby epic 3.3. See also: fullstaq-ruby/server-edition#47 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm using fullstaqruby on a new server (https://github.com/fullstaq-labs/fullstaq-ruby-server-edition), it's an optimized ruby distribution that integrates nicely with rbenv.
The only problem I found was when capistrano-rbenv tried to check the versions folder. Checking the code I found that it was possible to change the value of rbenv_ruby_dir and worked great.
I've also had to modify the path to the rbenv bin file, but that's more or less documented (modifying the :rbenv_prefix setting), that can probably be documented on the fullstaqruby github readme.
If you are ok I think it would be good to document the option, in case someone else find itself in the same position :)