Explicit support for Fullstaq Ruby#92
Merged
mattbrictson merged 1 commit intocapistrano:masterfrom Jul 10, 2020
FooBarWidget:main
Merged
Explicit support for Fullstaq Ruby#92mattbrictson merged 1 commit intocapistrano:masterfrom FooBarWidget:main
mattbrictson merged 1 commit intocapistrano:masterfrom
FooBarWidget:main
Conversation
|
Thanks for the PR! This project lacks automated tests, which makes reviewing and approving PRs somewhat difficult. Please make sure that your contribution has not broken backwards compatibility or introduced any risky changes. Generated by 🚫 Danger |
Fullstaq Ruby installs Ruby to /usr/lib/fullstaq-ruby/versions (of which /usr/lib/rbenv/versions is a symlink to). The currently documented way to support this is via setting `rbenv_ruby` to /usr/lib/fullstaq-ruby/versions, as implemented in pull request #91. However, the drawback of this approach is that SSHKit command mappings don't work. When one calls... execute(:ruby, '-v') ...capistrano-rbenv ends up executing $HOME/.rbenv/bin/rbenv. But Rbenv is not installed there, but in /usr/lib/rbenv/bin/rbenv. This change adds full support for Fullstaq Ruby, in a way that makes SSHKit command mappings work. Requires Fullstaq Ruby epic 3.3. See also: fullstaq-ruby/server-edition#47 (comment)
mattbrictson
approved these changes
Jul 10, 2020
Member
mattbrictson
left a comment
There was a problem hiding this comment.
I don't have a way to test this, but it seems good to me. Thanks for the PR!
| # [master][] | ||
|
|
||
| * Your contribution here! | ||
| * [#92](https://github.com/capistrano/rbenv/pull/92): Explicit support for Fullstaq Ruby - [@FooBarWidget](https://github.com/FooBarWidget) |
|
|
||
| # config/deploy.rb | ||
| set :rbenv_type, :user # or :system, depends on your rbenv setup | ||
| set :rbenv_type, :user # or :system, or :fullstaq (for Fullstaq Ruby), depends on your rbenv setup |
Member
There was a problem hiding this comment.
Thanks for updating the docs!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fullstaq Ruby installs Ruby to /usr/lib/fullstaq-ruby/versions (of which /usr/lib/rbenv/versions is a symlink to). The currently documented way to support this is via setting
rbenv_rubyto /usr/lib/fullstaq-ruby/versions, as implemented in pull request #91. However, the drawback of this approach is that SSHKit command mappings don't work. When one calls......capistrano-rbenv ends up executing $HOME/.rbenv/bin/rbenv. But Rbenv is not installed there, but in /usr/lib/rbenv/bin/rbenv.
This change adds full support for Fullstaq Ruby, in a way that makes SSHKit command mappings work.
Requires Fullstaq Ruby epic 3.3. See also:
fullstaq-ruby/server-edition#47 (comment)