The expand logic for env tag options has been modified, and the customOptions function has been refactored#349
Merged
caarlos0 merged 7 commits intocaarlos0:mainfrom Dec 12, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 625 618 -7
=========================================
- Hits 625 618 -7 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Sorry, the two "fix: typo" commits were because I forgot to run the test cases. |
Owner
|
thank you! |
oxzi
added a commit
to oxzi/caarlos0-env
that referenced
this pull request
Dec 18, 2024
The commit 6f3a5c0 from PR caarlos0#349, merged between the last two releases, changed the parsing logic for Options, especially allowing to merge map types. While this was already the case for Options.FuncMap, this breaks the API promise of Options.Environment to set "[e]nvironment keys and values that will be accessible for the service". In particular, this allowed an environment bleed while explicitly setting a custom environment, e.g., for testing purposes. This change reverts merging a custom Options.Environment with the default environment, if set.
caarlos0
pushed a commit
that referenced
this pull request
Dec 20, 2024
The commit 6f3a5c0 from PR #349, merged between the last two releases, changed the parsing logic for Options, especially allowing to merge map types. While this was already the case for Options.FuncMap, this breaks the API promise of Options.Environment to set "[e]nvironment keys and values that will be accessible for the service". In particular, this allowed an environment bleed while explicitly setting a custom environment, e.g., for testing purposes. This change reverts merging a custom Options.Environment with the default environment, if set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m not sure if you accept these two commits.