Options.Environment: Do not merge with default env#353
Merged
caarlos0 merged 1 commit intocaarlos0:mainfrom Dec 20, 2024
Merged
Options.Environment: Do not merge with default env#353caarlos0 merged 1 commit intocaarlos0:mainfrom
caarlos0 merged 1 commit intocaarlos0:mainfrom
Conversation
The commit 6f3a5c0 from PR caarlos0#349, merged between the last two releases, changed the parsing logic for Options, especially allowing to merge map types. While this was already the case for Options.FuncMap, this breaks the API promise of Options.Environment to set "[e]nvironment keys and values that will be accessible for the service". In particular, this allowed an environment bleed while explicitly setting a custom environment, e.g., for testing purposes. This change reverts merging a custom Options.Environment with the default environment, if set.
Owner
|
oh, good catch! thanks! gonna release this asap :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit 6f3a5c0 from PR #349, merged between the last two releases, changed the parsing logic for Options, especially allowing to merge map types. While this was already the case for Options.FuncMap, this breaks the API promise of Options.Environment to set "[e]nvironment keys and values that will be accessible for the service". In particular, this allowed an environment bleed while explicitly setting a custom environment, e.g., for testing purposes.
This change reverts merging a custom Options.Environment with the default environment, if set.