Skip to content

Legacy improvements to support teratestnet network#65

Merged
oskarszoon merged 6 commits into
bsv-blockchain:mainfrom
oskarszoon:feature/legacy-teratestnet
Oct 28, 2025
Merged

Legacy improvements to support teratestnet network#65
oskarszoon merged 6 commits into
bsv-blockchain:mainfrom
oskarszoon:feature/legacy-teratestnet

Conversation

@oskarszoon

Copy link
Copy Markdown
Contributor

No description provided.

@oskarszoon oskarszoon marked this pull request as ready for review October 28, 2025 12:01
@github-actions

github-actions Bot commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

🤖 Claude Code Review

Status: Complete


Summary: Changes look good. All previously reported issues have been fixed.

Fixes Applied:

  • ✅ Deadlock prevention: Added buffered channels and non-blocking sends
  • ✅ Comment accuracy: Updated INV listener comment to reflect actual behavior
  • ✅ Missing return: Added return statement after handleRelayTxMsg to prevent fall-through

Changes Reviewed:

  1. TeraTestNet Support - Adds teratestnet network configuration alongside testnet/regtest
  2. Kafka Listener Control - Improved state-based control with separate channels for block vs transaction listeners
  3. Genesis Block Handling - Now includes genesis block in header responses for SVNode compatibility
  4. Hash Conversion Utilities - New helper functions with comprehensive test coverage

No additional issues found.

Comment thread services/legacy/netsync/manager.go
Comment thread services/legacy/netsync/manager.go
Comment thread services/legacy/peer_server.go Outdated
@sonarqubecloud

Copy link
Copy Markdown

@oskarszoon oskarszoon self-assigned this Oct 28, 2025
@oskarszoon oskarszoon merged commit ab5c099 into bsv-blockchain:main Oct 28, 2025
10 of 11 checks passed
ordishs added a commit to ordishs/teranode that referenced this pull request Jan 12, 2026
Add Known Performance Limitations section explaining slow catchup issue:
- Recursive CTE query becomes expensive as blockchain grows
- Cache is completely invalidated on every StoreBlock call
- Results in query re-execution for every block during catchup
- Document potential incremental cache optimization approach
- Reference internal issue #4374 tracking this optimization
- Provide seeding workaround for faster initial sync

Addresses issue bsv-blockchain#65 from teranode-review
oskarszoon added a commit that referenced this pull request May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants