Ensure first transaction in subtree is coinbase placeholder#64
Merged
Conversation
icellan
approved these changes
Oct 27, 2025
2141d8a to
e93a15e
Compare
Contributor
|
🤖 Claude Code Review Status: Complete Current Review: History:
Summary: |
|
oskarszoon
approved these changes
Oct 28, 2025
Merged
7 tasks
oskarszoon
added a commit
that referenced
this pull request
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This pull request strengthens the validation logic for blocks by enforcing and testing that the first transaction in the first subtree is a coinbase placeholder. It makes this check active in the production code and adds comprehensive tests to ensure correct and incorrect scenarios are handled as expected.
Validation logic improvements:
Block.Validto require that the first transaction in the first subtree is a coinbase placeholder, returning an error if not.Testing improvements:
TestBlock_Valid_CoinbasePlaceholderCheckinBlock_test.gothat covers: