Conversation
- Add import for `strconv` - Remove the `dial` function and its associated comments - Update `NewRediStore` to include `username` parameter - Replace `dial` with `dialClient` in `NewRediStore` - Remove `dialWithDB` function - Add `dialClient` function with username and database handling - Update `NewRediStoreWithDB` to include `username` parameter - Replace `dialWithDB` with `dialClient` in `NewRediStoreWithDB` - Update tests to include `username` parameter in `NewRediStore` and `NewRediStoreWithDB` calls fix #65 Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
…tion - Update authentication comments to include username and password - Clarify that keyPairs are used for cookie encryption only - Add username parameter to Redis connection details in comments - Simplify and clarify comments on Redis connection parameters and return values Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
karantan
added a commit
to karantan/contrib
that referenced
this pull request
Jul 24, 2025
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strconvdialfunction and its associated commentsNewRediStoreto includeusernameparameterdialwithdialClientinNewRediStoredialWithDBfunctiondialClientfunction with username and database handlingNewRediStoreWithDBto includeusernameparameterdialWithDBwithdialClientinNewRediStoreWithDBusernameparameter inNewRediStoreandNewRediStoreWithDBcallsfix #65