Adding username as parameter for the redis authentication#65
Closed
kerkmann wants to merge 1 commit intoboj:masterfrom
Closed
Adding username as parameter for the redis authentication#65kerkmann wants to merge 1 commit intoboj:masterfrom
kerkmann wants to merge 1 commit intoboj:masterfrom
Conversation
7 tasks
karelkryda
reviewed
Sep 2, 2023
Comment on lines
+146
to
+155
| if username != "" { | ||
| if _, err := c.Do("AUTH", password); err != nil { | ||
| c.Close() | ||
| return nil, err | ||
| } | ||
| } else { | ||
| if _, err := c.Do("AUTH", username, password); err != nil { | ||
| c.Close() | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
You switched the call in the condition:
- empty
usernamecalls the command using theusernamevariable - a non-empty
usernamecalls the command without using theusernamevariable
There was a problem hiding this comment.
Yes, sorry for the mistaken.
I don't think this PR will be accepted by the author.
The repo is inactive for such a long time.
There was a problem hiding this comment.
Besides, I suggest that using tcp link url to include username and database index is the trick to pass through this dilemma if your library is dependent on redistore.
There was a problem hiding this comment.
Yes, sorry for the mistaken.
I don't think this PR will be accepted by the author.
The repo is inactive for such a long time.
Yes, I am of the same opinion. Perhaps an authentik should use a different library than this one if we want to implement modern Redis features.
7 tasks
appleboy
added a commit
that referenced
this pull request
Feb 10, 2025
- Add import for `strconv` - Remove the `dial` function and its associated comments - Update `NewRediStore` to include `username` parameter - Replace `dial` with `dialClient` in `NewRediStore` - Remove `dialWithDB` function - Add `dialClient` function with username and database handling - Update `NewRediStoreWithDB` to include `username` parameter - Replace `dialWithDB` with `dialClient` in `NewRediStoreWithDB` - Update tests to include `username` parameter in `NewRediStore` and `NewRediStoreWithDB` calls fix #65 Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
appleboy
added a commit
that referenced
this pull request
Feb 10, 2025
* refactor: refactor RediStore to support username parameter - Add import for `strconv` - Remove the `dial` function and its associated comments - Update `NewRediStore` to include `username` parameter - Replace `dial` with `dialClient` in `NewRediStore` - Remove `dialWithDB` function - Add `dialClient` function with username and database handling - Update `NewRediStoreWithDB` to include `username` parameter - Replace `dialWithDB` with `dialClient` in `NewRediStoreWithDB` - Update tests to include `username` parameter in `NewRediStore` and `NewRediStoreWithDB` calls fix #65 Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com> * docs: clarify and update comments for authentication and Redis connection - Update authentication comments to include username and password - Clarify that keyPairs are used for cookie encryption only - Add username parameter to Redis connection details in comments - Simplify and clarify comments on Redis connection parameters and return values Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com> --------- Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intention
I am using Authentik which is using your library. There is an open ticket for settings the Redis username. Sadly the username is not set in this library. Without fixing that issuer here, it's impossible to fix it in Authentik. ^^"
Changes
Adding the username as optional parameter.
I hope the PR is looking good, I am not a go developer. Please let me know if something is wrong/missing.