consensus/parlia: set nonce before evm run#2185
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Jan 29, 2024
buddh0:Parlia_systemtx_SetNonce
Merged
consensus/parlia: set nonce before evm run#2185zzzckck merged 1 commit intobnb-chain:developfrom buddh0:Parlia_systemtx_SetNonce
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:Parlia_systemtx_SetNonce
Conversation
zzzckck
approved these changes
Jan 26, 2024
unclezoro
approved these changes
Jan 29, 2024
This was referenced Feb 18, 2024
Merged
Contributor
|
I would like to raise the fact that while indeed that consensus will not break because of such change, it do breaks the determinism of our Firehose tracing system as it expects that the execution happens in the same order whatever version of the node you use. Now if I reprocess with v1.3.8 to trace the full chain and again with v1.3.9 I will get different results because the I would like see if the BNB team would be open to revert the change. Seems that the only reason was to better align with Geth ways of doing things, so doesn't feel like it's a strict requirement for a bug fix of some upcoming feature. |
minh-bq
added a commit
to axieinfinity/ronin-archive
that referenced
this pull request
Apr 5, 2024
…ion (#434) Currently, in system transaction we increase nonce after transaction execution which is not consistent with normal transaction. This change does not require a hardfork as: - Nonce is not used when executing transaction in virtual machine - Consortium-v2 is after Byzantium so we don't fall through the path to calculate root hash after transaction execution Reference: bnb-chain/bsc#2185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
consensus/parlia: set nonce before evm run
Rationale
It's strange to set nonce after execute tx, so align with it in TransitionDb
no need to use hardfork to control, there are 3 reasons:
Example
add an example CLI or API response...
Changes
Notable changes: