This repository was archived by the owner on Jun 6, 2025. It is now read-only.
consortium-v2: increase the nonce of sender before transaction execution#434
Merged
minh-bq merged 1 commit intoaxieinfinity:masterfrom Apr 5, 2024
minh-bq:fix/system-txs-set-nonce
Merged
consortium-v2: increase the nonce of sender before transaction execution#434minh-bq merged 1 commit intoaxieinfinity:masterfrom minh-bq:fix/system-txs-set-nonce
minh-bq merged 1 commit intoaxieinfinity:masterfrom
minh-bq:fix/system-txs-set-nonce
Conversation
andicrypt
approved these changes
Apr 4, 2024
DNK90
approved these changes
Apr 5, 2024
Currently, in system transaction we increase nonce after transaction execution which is not consistent with normal transaction. This change does not require a hardfork as: - Nonce is not used when executing transaction in virtual machine - Consortium-v2 is after Byzantium so we don't fall through the path to calculate root hash after transaction execution Reference: bnb-chain/bsc#2185
Francesco4203
pushed a commit
to Francesco4203/ronin
that referenced
this pull request
Jun 18, 2024
…ion (axieinfinity#434) Currently, in system transaction we increase nonce after transaction execution which is not consistent with normal transaction. This change does not require a hardfork as: - Nonce is not used when executing transaction in virtual machine - Consortium-v2 is after Byzantium so we don't fall through the path to calculate root hash after transaction execution Reference: bnb-chain/bsc#2185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in system transaction we increase nonce after transaction execution
which is not consistent with normal transaction. This change does not require a
hardfork as:
calculate root hash after transaction execution
Reference: bnb-chain/bsc#2185