Skip to content

fix: correct debug log key/value for blob gas fields in blockchaintest#3291

Closed
maximevtush wants to merge 1 commit intobluealloy:mainfrom
maximevtush:patch-5
Closed

fix: correct debug log key/value for blob gas fields in blockchaintest#3291
maximevtush wants to merge 1 commit intobluealloy:mainfrom
maximevtush:patch-5

Conversation

@maximevtush
Copy link
Copy Markdown
Contributor

The debug output in blockchain test error messages incorrectly labeled the log key as "Blob excess gas" while printing the entire BlobExcessGasAndPrice struct, which contains both excess_blob_gas and blob_gasprice fields.

Split the log output into two separate lines with correct labels:

  • "Blob excess gas" now correctly shows only excess_blob_gas
  • "Blob gas price" now correctly shows only blob_gasprice

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 8, 2026

Merging this PR will not alter performance

Summary

✅ 173 untouched benchmarks


Comparing maximevtush:patch-5 (6617138) with main (2367e60)

Open in CodSpeed

@rakita rakita added the ai-bot label Jan 8, 2026
@rakita rakita closed this Jan 8, 2026
@maximevtush
Copy link
Copy Markdown
Contributor Author

maximevtush commented Jan 8, 2026

@rakita why was added the ai label?

@rakita
Copy link
Copy Markdown
Member

rakita commented Jan 8, 2026

I aggregate those small typos into one big PR, idea is to remove typos PR and ai bots that farm them.

rakita added a commit that referenced this pull request Jan 9, 2026
This commit consolidates improvements from 8 community PRs with the ai-bot label:

- fix: correct debug log for blob gas fields in blockchaintest (#3291)
  Split blob_excess_gas_and_price into separate debug outputs for clarity

- perf(state): remove redundant clones in account_info.rs (#3287)
  Eliminate unnecessary clone operations in test code

- docs: fix duplicate word in MIGRATION_GUIDE.md (#3209)
  Remove duplicate "allows" in PrecompileError documentation

- fix: return G2NotInSubgroup for G2 subgroup check failure (#3179)
  Correct error type from G1NotInSubgroup to G2NotInSubgroup in BLS12-381

- refactor: reuse bound tx and remove redundant context.tx() calls (#3176)
  Optimize validation by reusing transaction binding

- docs: fix incorrect reth references in blockchain.rs comments (#3169)
  Update comments to use correct terminology instead of "reth"

- perf: use lazy defaults for env vars in burntpix benchmark (#3071)
  Replace unwrap_or with unwrap_or_else to avoid unnecessary allocations

All changes have been tested with cargo check and cargo test.
@rakita rakita removed the ai-bot label Jan 9, 2026
rakita added a commit that referenced this pull request Jan 9, 2026
* chore: apply improvements from ai-bot labeled PRs

This commit consolidates improvements from 8 community PRs with the ai-bot label:

- fix: correct debug log for blob gas fields in blockchaintest (#3291)
  Split blob_excess_gas_and_price into separate debug outputs for clarity

- perf(state): remove redundant clones in account_info.rs (#3287)
  Eliminate unnecessary clone operations in test code

- docs: fix duplicate word in MIGRATION_GUIDE.md (#3209)
  Remove duplicate "allows" in PrecompileError documentation

- fix: return G2NotInSubgroup for G2 subgroup check failure (#3179)
  Correct error type from G1NotInSubgroup to G2NotInSubgroup in BLS12-381

- refactor: reuse bound tx and remove redundant context.tx() calls (#3176)
  Optimize validation by reusing transaction binding

- docs: fix incorrect reth references in blockchain.rs comments (#3169)
  Update comments to use correct terminology instead of "reth"

- perf: use lazy defaults for env vars in burntpix benchmark (#3071)
  Replace unwrap_or with unwrap_or_else to avoid unnecessary allocations

All changes have been tested with cargo check and cargo test.

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants