Skip to content

docs: fix incorrect reth references in blockchain.rs comments#3169

Closed
forkfury wants to merge 1 commit intobluealloy:mainfrom
forkfury:fix/update-comment-terminology
Closed

docs: fix incorrect reth references in blockchain.rs comments#3169
forkfury wants to merge 1 commit intobluealloy:mainfrom
forkfury:fix/update-comment-terminology

Conversation

@forkfury
Copy link
Copy Markdown
Contributor

Replace "reth model" with "TxEnv" and "reth expects" with "expected format" in comments. These were outdated references since revm is an independent project, not part of reth.

Replace "reth model" with "TxEnv" and "reth expects" with "expected format" 
in comments. These were outdated references since revm is an independent 
project, not part of reth.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 13, 2025

CodSpeed Performance Report

Merging #3169 will not alter performance

Comparing forkfury:fix/update-comment-terminology (d440662) with main (84d41bc)

Summary

✅ 173 untouched

@rakita rakita added the ai-bot label Nov 13, 2025
@rakita rakita closed this Nov 13, 2025
rakita added a commit that referenced this pull request Jan 9, 2026
This commit consolidates improvements from 8 community PRs with the ai-bot label:

- fix: correct debug log for blob gas fields in blockchaintest (#3291)
  Split blob_excess_gas_and_price into separate debug outputs for clarity

- perf(state): remove redundant clones in account_info.rs (#3287)
  Eliminate unnecessary clone operations in test code

- docs: fix duplicate word in MIGRATION_GUIDE.md (#3209)
  Remove duplicate "allows" in PrecompileError documentation

- fix: return G2NotInSubgroup for G2 subgroup check failure (#3179)
  Correct error type from G1NotInSubgroup to G2NotInSubgroup in BLS12-381

- refactor: reuse bound tx and remove redundant context.tx() calls (#3176)
  Optimize validation by reusing transaction binding

- docs: fix incorrect reth references in blockchain.rs comments (#3169)
  Update comments to use correct terminology instead of "reth"

- perf: use lazy defaults for env vars in burntpix benchmark (#3071)
  Replace unwrap_or with unwrap_or_else to avoid unnecessary allocations

All changes have been tested with cargo check and cargo test.
@rakita rakita removed the ai-bot label Jan 9, 2026
rakita added a commit that referenced this pull request Jan 9, 2026
* chore: apply improvements from ai-bot labeled PRs

This commit consolidates improvements from 8 community PRs with the ai-bot label:

- fix: correct debug log for blob gas fields in blockchaintest (#3291)
  Split blob_excess_gas_and_price into separate debug outputs for clarity

- perf(state): remove redundant clones in account_info.rs (#3287)
  Eliminate unnecessary clone operations in test code

- docs: fix duplicate word in MIGRATION_GUIDE.md (#3209)
  Remove duplicate "allows" in PrecompileError documentation

- fix: return G2NotInSubgroup for G2 subgroup check failure (#3179)
  Correct error type from G1NotInSubgroup to G2NotInSubgroup in BLS12-381

- refactor: reuse bound tx and remove redundant context.tx() calls (#3176)
  Optimize validation by reusing transaction binding

- docs: fix incorrect reth references in blockchain.rs comments (#3169)
  Update comments to use correct terminology instead of "reth"

- perf: use lazy defaults for env vars in burntpix benchmark (#3071)
  Replace unwrap_or with unwrap_or_else to avoid unnecessary allocations

All changes have been tested with cargo check and cargo test.

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants