Add cli esplora example by evanlinjin · Pull Request #1040 · bitcoindevkit/bdk

evanlinjin · 2023-07-20T00:53:07Z

Description

This PR builds on top of #1034 and adds a cli-example for our esplora chain-src crate.

Notes to the reviewers

Don't merge this until #1034 is merged. The only relevant commit is 5ff0412.

Changelog notice

Add cli-example for esplora.

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing

New Features:

* [ ] I've added tests for the new feature

I've added docs for the new feature

example-crates/example_esplora/src/main.rs

LLFourn · 2023-08-03T06:29:25Z

Thanks. In general this example could do with a lot more comments explaining what's happening and why. With examples it's better to be on the side of too many comments rather than too little.

example-crates/example_esplora/src/main.rs

notmandatory · 2023-08-08T02:59:05Z

While testing I found a bug in esplora blocking_ext.rs and also exists in async_ext.rs. When syncing the stop_gap is set to usize::MAX and the update_tx_graph functions fail on the addition here:

                if last_index > last_active_index.map(|i| i + stop_gap as u32) {
                    break;
                }

Easy enough to fix:

                if last_index > last_active_index.map(|i| i.saturating_add(stop_gap as u32)) {
                    break;
                }

example-crates/example_esplora/src/main.rs

LLFourn · 2023-08-15T04:07:09Z

LGTM but i think we are waiting on #1065 before this one.

example-crates/example_esplora/src/main.rs

danielabrozzoni · 2023-08-24T20:33:26Z

I just pushed:

Evan's commit, rebased
A commit on top, to be squashed, fixing most of the review comments
I rebased this whole PR on fix: spks_of_all_keychains() shouldn't return an infinite iterator for non-wildcard descriptors #1093 since I suppose it's going to be merged before this one

While testing I found a bug in esplora blocking_ext.rs and also exists in async_ext.rs. When syncing the stop_gap is set to usize::MAX and the update_tx_graph functions fail on the addition here:

@notmandatory I don't understand how to reproduce this. Does it happen with every call to sync?

LLFourn addressing his comments on bitcoindevkit#1040

LLFourn · 2023-08-25T06:35:20Z

I've made some requested changes. Rather than go back and forth too much I made a PR to show what I had in mind: evanlinjin#6

(note I accidentally push to this PR branch at some point. Ignore that. I've reset it back to how it was).

example-crates/example_esplora/src/main.rs

LLFourn addressing his comments on bitcoindevkit#1040

danielabrozzoni · 2023-08-30T11:15:21Z

Changes from my last push (019fa4c):

I reviewed and cherry-picked @LLFourn's commits
I removed my fix from fix: spks_of_all_keychains() shouldn't return an infinite iterator for non-wildcard descriptors #1093 since it will take some time before it's ready
CI is broken, I'm waiting for ci: pin rustls 0.21.7 #1105, and then I'll rebase again

@evanlinjin I'd say this is ready to merge. Can you review the commits pushed on top, squash them, and ACK? Then I'll ACK as well :)

LLFourn addressing his comments on bitcoindevkit#1040

danielabrozzoni · 2023-08-31T09:01:53Z

Rebased after #1048 in order to fix CI

evanlinjin

Thanks for taking this forward @danielabrozzoni. Just a really small nit. Looks good otherwise.

crates/chain/src/tx_graph.rs

evanlinjin · 2023-08-31T09:48:05Z

I also tested everything. Works fine.

Co-authored-by: remix <remix7531@pm.me> Co-authored-by: LLFourn <lloyd.fourn@gmail.com> Co-authored-by: Daniela Brozzoni <danielabrozzoni@protonmail.com>

danielabrozzoni

ACK f41cc1c

notmandatory

ACK f41cc1c

I was also not able to reproduce the sync error I saw before.

notmandatory · 2023-08-31T19:55:30Z

I'm dismissing @LLFourn blocking review so this can be merged since it looks like comments are all addressed.

All comments addressed

notmandatory · 2023-09-04T05:36:31Z

ACK f41cc1c

I was also not able to reproduce the sync error I saw before.

I found the sync error mentioned above, created tests to repro and added fix in #1110 .

2090021 refactor: rename methods in EsploraExt and EsploraExtAsync (Vladimir Fomene) Pull request description: ### Description This PR fixes #1058. Built on top of #1040 ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [ ] I've added tests for the new feature * [ ] I've added docs for the new feature ACKs for top commit: realeinherjar: ACK 2090021 danielabrozzoni: ACK 2090021 - code looks good, `example_esplora` and `wallet_esplora_blocking` work just fine. Tree-SHA512: 5b5285aaa67a0c4e8174e480cceec7d934ec04a74d81740e1c82f6b8673c3e3d9c676dc43257a170320089efe2d3cb0d33123b4a395fc3e7fec63f85bdf70c79

evanlinjin requested review from LLFourn and danielabrozzoni July 20, 2023 00:53

evanlinjin self-assigned this Jul 20, 2023

evanlinjin added this to the 1.0.0-alpha.2 milestone Jul 20, 2023

evanlinjin force-pushed the esplora_example branch 2 times, most recently from 2bacc1f to f1b7da3 Compare July 28, 2023 06:10

nondiremanuel mentioned this pull request Jul 29, 2023

W31 Lib Team Call bitcoindevkit/.github#70

Closed

19 tasks

evanlinjin force-pushed the esplora_example branch from f1b7da3 to 7a4231b Compare August 1, 2023 11:01

LLFourn requested changes Aug 3, 2023

View reviewed changes

evanlinjin force-pushed the esplora_example branch from 7a4231b to 6a5b769 Compare August 4, 2023 04:54

benthecarman reviewed Aug 4, 2023

View reviewed changes

example-crates/example_esplora/src/main.rs Outdated Show resolved Hide resolved

evanlinjin force-pushed the esplora_example branch from 6a5b769 to 3dd481f Compare August 4, 2023 11:19

evanlinjin mentioned this pull request Aug 4, 2023

Rename methods of EsploraExt and EsploraAsyncExt #1058

Closed

benthecarman mentioned this pull request Aug 4, 2023

More effienct esplora syncing MutinyWallet/mutiny-node#690

Merged

evanlinjin requested a review from LLFourn August 5, 2023 04:40

vladimirfomene reviewed Aug 8, 2023

View reviewed changes

example-crates/example_esplora/src/main.rs Outdated Show resolved Hide resolved

example-crates/example_esplora/src/main.rs Outdated Show resolved Hide resolved

example-crates/example_esplora/src/main.rs Show resolved Hide resolved

nondiremanuel mentioned this pull request Aug 8, 2023

W33 Lib Team Call bitcoindevkit/.github#72

Closed

26 tasks

vladimirfomene mentioned this pull request Aug 9, 2023

Rename methods of esplora ext #1070

Merged

5 tasks

danielabrozzoni mentioned this pull request Aug 16, 2023

refactor!(chain): Unify ChangeSet nomenclature #1065

Merged

3 tasks

LLFourn requested changes Aug 21, 2023

View reviewed changes

example-crates/example_esplora/src/main.rs Outdated Show resolved Hide resolved

nondiremanuel mentioned this pull request Aug 22, 2023

W35 Lib Team Call bitcoindevkit/.github#74

Closed

30 tasks

danielabrozzoni force-pushed the esplora_example branch from 3dd481f to 45cbe6b Compare August 24, 2023 20:25

LLFourn added a commit to LLFourn/bdk that referenced this pull request Aug 25, 2023

fix: Simplify esplora cli example

e677824

LLFourn addressing his comments on bitcoindevkit#1040

LLFourn added a commit to evanlinjin/bdk that referenced this pull request Aug 25, 2023

fix: Simplify esplora cli example

0dc88d5

LLFourn addressing his comments on bitcoindevkit#1040

LLFourn mentioned this pull request Aug 25, 2023

fix: Simplify esplora cli example evanlinjin/bdk#6

Closed

LLFourn previously requested changes Aug 25, 2023

View reviewed changes

example-crates/example_esplora/src/main.rs Show resolved Hide resolved

example-crates/example_esplora/src/main.rs Outdated Show resolved Hide resolved

example-crates/example_esplora/src/main.rs Outdated Show resolved Hide resolved

LLFourn force-pushed the esplora_example branch from 0dc88d5 to 45cbe6b Compare August 25, 2023 06:37

notmandatory assigned danielabrozzoni Aug 29, 2023

danielabrozzoni pushed a commit to evanlinjin/bdk that referenced this pull request Aug 30, 2023

TO BE SQUASHED: Simplify esplora cli example

019fa4c

LLFourn addressing his comments on bitcoindevkit#1040

danielabrozzoni force-pushed the esplora_example branch from 45cbe6b to 019fa4c Compare August 30, 2023 11:03

danielabrozzoni pushed a commit to evanlinjin/bdk that referenced this pull request Aug 31, 2023

TO BE SQUASHED: Simplify esplora cli example

82b9af4

LLFourn addressing his comments on bitcoindevkit#1040

danielabrozzoni force-pushed the esplora_example branch from ab33b90 to 12c49bf Compare August 31, 2023 09:00

evanlinjin commented Aug 31, 2023

View reviewed changes

crates/chain/src/tx_graph.rs Outdated Show resolved Hide resolved

danielabrozzoni force-pushed the esplora_example branch from f8a893d to 3c1e5d4 Compare August 31, 2023 10:03

evanlinjin and others added 2 commits August 31, 2023 13:07

feat: add cli example for esplora

da8cfd3

Co-authored-by: remix <remix7531@pm.me> Co-authored-by: LLFourn <lloyd.fourn@gmail.com> Co-authored-by: Daniela Brozzoni <danielabrozzoni@protonmail.com>

fix: s/index_tx_graph/indexed_tx_graph/g

f41cc1c

danielabrozzoni force-pushed the esplora_example branch from 3c1e5d4 to f41cc1c Compare August 31, 2023 11:07

danielabrozzoni approved these changes Aug 31, 2023

View reviewed changes

danielabrozzoni requested a review from LLFourn August 31, 2023 11:21

notmandatory approved these changes Aug 31, 2023

View reviewed changes

notmandatory merged commit 8321aaa into bitcoindevkit:master Aug 31, 2023

nondiremanuel mentioned this pull request Sep 10, 2023

W37 Lib Team Call bitcoindevkit/.github#76

Closed

41 tasks

notmandatory mentioned this pull request Oct 11, 2023

Release 1.0.0-alpha.2 #1168

Closed

12 tasks

Conversation

evanlinjin commented Jul 20, 2023

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LLFourn commented Aug 3, 2023

Uh oh!

Uh oh!

notmandatory commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LLFourn commented Aug 15, 2023

Uh oh!

Uh oh!

danielabrozzoni commented Aug 24, 2023

Uh oh!

LLFourn commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danielabrozzoni commented Aug 30, 2023

Uh oh!

danielabrozzoni commented Aug 31, 2023

Uh oh!

evanlinjin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

evanlinjin commented Aug 31, 2023

Uh oh!

danielabrozzoni left a comment

Choose a reason for hiding this comment

Uh oh!

notmandatory left a comment

Choose a reason for hiding this comment

Uh oh!

notmandatory commented Aug 31, 2023

Uh oh!

notmandatory commented Sep 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

notmandatory commented Aug 8, 2023 •

edited

Loading

LLFourn commented Aug 25, 2023 •

edited

Loading