Description

Removed TransactionDetails and changed Wallet::get_tx to return a CanonicalTx, and TxBuilder::finish to return only a PartiallySignedTransaction. This should fix #922 and fix #1015.

I also added Wallet functions to get a Transaction send and receive amounts, fee, and FeeRate.

see: #922 (comment)

Notes to the reviewers

Alot of wallet tests had to change since TxBuilder::finish only returns a PSBT now.

I added a new CalculateFeeError which follows changes coming in #1028.

Changelog notice

Added

• Wallet::sent_and_received function
• Wallet::calculate_fee and Wallet::calculate_fee_rate functions
• Wallet::error::CalculateFeeError
• Wallet::insert_txout function to allow inserting foreign TxOuts

BREAKING CHANGES:

Removed

• TransactionDetails struct

Changed

• Wallet::get_tx now returns CanonicalTx instead of TransactionDetails
• TxBuilder::finish now returns only a PartiallySignedTransaction

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature