Skip to content

ci: bump cirruslabs actions versions#34815

Merged
fanquake merged 1 commit intobitcoin:masterfrom
willcl-ark:bump-cirruslabs-actions
Mar 12, 2026
Merged

ci: bump cirruslabs actions versions#34815
fanquake merged 1 commit intobitcoin:masterfrom
willcl-ark:bump-cirruslabs-actions

Conversation

@willcl-ark
Copy link
Member

Fix CI deprecation warnings of form: Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: cirruslabs/cache/restore@v4.

As these are hiding in .github/actions/**/*.yml they were forgotten by the (two) previous PR(s) 😢

#34802
#34344

@DrahtBot DrahtBot added the Tests label Mar 12, 2026
@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 12, 2026

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

@maflcko
Copy link
Member

maflcko commented Mar 12, 2026

As these are hiding in .github/actions/**/*.yml they were forgotten by the (two) previous PR(s) 😢

No, I found them, but I can't see the releases or tags in https://github.com/cirruslabs/cache/tags. Can you link to them?

@willcl-ark
Copy link
Member Author

As these are hiding in .github/actions/**/*.yml they were forgotten by the (two) previous PR(s) 😢

No, I found them, but I can't see the releases or tags in cirruslabs/cache/tags. Can you link to them?

Fair point, they do not exist there. They are in README.md and also on https://github.com/cirruslabs/cache/branches but I'm not sure why they don't use tags, I guess because of how they rebase their changes onto branches?

I think it's a cirrus override oddity?

@maflcko
Copy link
Member

maflcko commented Mar 12, 2026

lgtm ACK 9a968ad

Ok, I see. Thx for explaining.

@fanquake fanquake merged commit 56983a4 into bitcoin:master Mar 12, 2026
26 checks passed
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Mar 12, 2026
@fanquake fanquake mentioned this pull request Mar 12, 2026
@fanquake
Copy link
Member

Backported to 31.x in #34800.

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Mar 12, 2026
@fanquake fanquake mentioned this pull request Mar 12, 2026
@fanquake
Copy link
Member

Backported to 30.x in #34805.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants