Draft
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. |
Member
|
Did you mean to make this a PR against 31.x? |
Github-Pull: bitcoin#34755 Rebased-From: 168997e
Github-Pull: bitcoin#34755 Rebased-From: 0ebc689
Github-Pull: bitcoin#34802 Rebased-From: fadaa7d
To work around bitcoin#34810 Github-Pull: bitcoin#34814 Rebased-From: faae981
5fa8e35 to
a74dfe3
Compare
Github-Pull: bitcoin#34815 Rebased-From: 9a968ad
the test silently passes on master because SetupAddressRelay isn't called by default for inbound connections. Github-Pull: bitcoin#34750 Rebased-From: ecb5ce6
since we're bumping mocktime more than CHAIN_SYNC_TIMEOUT = 20 * 60, it's possible for disconnections like this to happen in the test: $ test/functional/p2p_addr_relay.py --randomseed=7758649581790797022 ... TestFramework (INFO): Check that we answer getaddr messages only once per connection TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:58829 due to [Errno 54] Connection reset by peer ... Github-Pull: bitcoin#34750 Rebased-From: 7ee8c0a
we don't need to send GETADDR for initial self announcement anymore + can construct addr_receivers using AddrReceiver(send_getaddr=False). however we would need to send an empty ADDR message to each of the addr_receivers to initialise addr relay for inbound connections. so current code is simpler and we can just clarify the comment. Github-Pull: bitcoin#34750 Rebased-From: 57bfa86
* Show preview and ask for confirmation before git clean unless used with "--force" * Error out when trying to pass args such as "guix-clean --help" Github-Pull: bitcoin#34776 Rebased-From: be6d24e
Github-Pull: bitcoin#33144 Rebased-From: fa6497b
Calling shutil.make_archive(), does not preserve symlinks when using the zip format, see python/cpython#139679. Call `zip` using subprocess instead. This code is only run when using a macos machine, and I think it's safe to assume that zip is available, same as codesign, and all other tools we call in this script. Github-Pull: bitcoin#34787 Rebased-From: ab137cb
Rather than looking for /translations, which might not exist (it doesn't in a recent brew installed qt on macOS). i.e: ```bash ls /opt/homebrew/opt/qtbase/share/qt doc libexec metatypes mkspecs modules plugins sbom ``` Github-Pull: bitcoin#34787 Rebased-From: 66d80d5
Github-Pull: bitcoin#34787 Rebased-From: d03e3be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports: