depends: cleanup meta files#34755
Merged
fanquake merged 2 commits intobitcoin:masterfrom Mar 11, 2026
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
hebasto
approved these changes
Mar 10, 2026
Comment on lines
+28
to
+30
| define $(package)_postprocess_cmds | ||
| rm -rf share | ||
| endef |
Member
There was a problem hiding this comment.
Unfortunately, there is no Boost's CMake variable to exclude *.natvis files.
Member
Author
|
Guix Build (x86_64): 1d470d3079f8aca86d223ba0595d927775b97d3397ca1c477dae4f966dbaaef0 guix-build-0ebc6891e216/output/aarch64-linux-gnu/SHA256SUMS.part
2a80a94e3d690ffd6ae6cd4a4819118ff04df28f9ccd84a0fd04134c1553a6c3 guix-build-0ebc6891e216/output/aarch64-linux-gnu/bitcoin-0ebc6891e216-aarch64-linux-gnu-debug.tar.gz
e0886d0ae5a776c4cafa9bab7ee8448629575dbf25578f6f975ba918849cf2b7 guix-build-0ebc6891e216/output/aarch64-linux-gnu/bitcoin-0ebc6891e216-aarch64-linux-gnu.tar.gz
d5cacdb64c0c8e077a0def0f2da0eb16c4339b1c7763e1aeb70405898ac26ba3 guix-build-0ebc6891e216/output/arm-linux-gnueabihf/SHA256SUMS.part
0a2ab75ccfe09763c48a859b195ad22cdf13c9dac413b59230839145ee69fa00 guix-build-0ebc6891e216/output/arm-linux-gnueabihf/bitcoin-0ebc6891e216-arm-linux-gnueabihf-debug.tar.gz
0241029e04ef2511ac338a2164d05ff6215a38141de41452661bf3d657b070b5 guix-build-0ebc6891e216/output/arm-linux-gnueabihf/bitcoin-0ebc6891e216-arm-linux-gnueabihf.tar.gz
e9c6b99fbec816e7e6ba96ec697b96b426a18563b2941573988b9cb4a6862ffb guix-build-0ebc6891e216/output/arm64-apple-darwin/SHA256SUMS.part
b9bc4b8c7769fb3d12530a9c8b55c212fd008f15548224e540278e70169aa503 guix-build-0ebc6891e216/output/arm64-apple-darwin/bitcoin-0ebc6891e216-arm64-apple-darwin-codesigning.tar.gz
4661c10803dc48d87ddd682864323f3969b214736082326a9a4eb0e7b15f076c guix-build-0ebc6891e216/output/arm64-apple-darwin/bitcoin-0ebc6891e216-arm64-apple-darwin-unsigned.tar.gz
c8298f48bf39a0029e401919c4daaa27d82b7868069172bbec63f01ffe24f183 guix-build-0ebc6891e216/output/arm64-apple-darwin/bitcoin-0ebc6891e216-arm64-apple-darwin-unsigned.zip
4111272bda23c91d2ac14df4a0c029d863e77443438509126e970fdfc66d6de9 guix-build-0ebc6891e216/output/dist-archive/bitcoin-0ebc6891e216.tar.gz
a119d4bc7e7cf00e569428b07fbdc41a7ac8e3a91109552f0a9cfd23eb8da51a guix-build-0ebc6891e216/output/powerpc64-linux-gnu/SHA256SUMS.part
8b01f0bde42d8ca63aeccc46bcb9b2f907e8544b10c210eeeb089bba1a0cd0e2 guix-build-0ebc6891e216/output/powerpc64-linux-gnu/bitcoin-0ebc6891e216-powerpc64-linux-gnu-debug.tar.gz
3b9357421f5f614926f0f8bd12e6c13fe9e430a8b0b8101d4418b878ba21813e guix-build-0ebc6891e216/output/powerpc64-linux-gnu/bitcoin-0ebc6891e216-powerpc64-linux-gnu.tar.gz
6491a00ce789a5acc0ce185e8166480f7d8970adde6c8ebbb5c0125e02612daa guix-build-0ebc6891e216/output/riscv64-linux-gnu/SHA256SUMS.part
a2e2bf012a3ef95cb228a0231efc958133c231ee12049148cd8e26775b4ea450 guix-build-0ebc6891e216/output/riscv64-linux-gnu/bitcoin-0ebc6891e216-riscv64-linux-gnu-debug.tar.gz
9f47af47f594f0c7c9ad8098a628402efd4c7db88f8d86343ce41f6ea0d24f9b guix-build-0ebc6891e216/output/riscv64-linux-gnu/bitcoin-0ebc6891e216-riscv64-linux-gnu.tar.gz
98c7ebb8e6caece8df8984d6db1d06a75b59f0ee9cb66bddff7be2aee7335f22 guix-build-0ebc6891e216/output/x86_64-apple-darwin/SHA256SUMS.part
f0e275c09c508f4ed187a6557301685e206509cbf8754cfa73157eb99c7f67af guix-build-0ebc6891e216/output/x86_64-apple-darwin/bitcoin-0ebc6891e216-x86_64-apple-darwin-codesigning.tar.gz
3cac318dee65a877ec1fbf1277ccee315b519443ded37128fd83e8cc85c0863e guix-build-0ebc6891e216/output/x86_64-apple-darwin/bitcoin-0ebc6891e216-x86_64-apple-darwin-unsigned.tar.gz
e6d7572ebb52e809fbff574216c770fc6169285a89b1d34adfe1c21d1a03f9b4 guix-build-0ebc6891e216/output/x86_64-apple-darwin/bitcoin-0ebc6891e216-x86_64-apple-darwin-unsigned.zip
c995afcb34ae9c548db2105a5c3adcb53a3f3c5dbbdd915acad7b630e795ece8 guix-build-0ebc6891e216/output/x86_64-linux-gnu/SHA256SUMS.part
f07ff630cdaf6d936e0163bdc0c8c6f618c690e63adb0a8a519644feef205dc2 guix-build-0ebc6891e216/output/x86_64-linux-gnu/bitcoin-0ebc6891e216-x86_64-linux-gnu-debug.tar.gz
b8544429c410c0b32cef0adcf17cc052ed19e5c6082c9945bc5c739f54bfd4ac guix-build-0ebc6891e216/output/x86_64-linux-gnu/bitcoin-0ebc6891e216-x86_64-linux-gnu.tar.gz
09199389a3b30e14fa960118629662e2f12277e1270572607bbc465bf3c4a5b7 guix-build-0ebc6891e216/output/x86_64-w64-mingw32/SHA256SUMS.part
3823cbb6504cde4d593f58ff354c5a9d77f8222ccf2b882fd1270293380b35de guix-build-0ebc6891e216/output/x86_64-w64-mingw32/bitcoin-0ebc6891e216-win64-codesigning.tar.gz
bbaaf1ca435d2302e9c83b95503f8d588ca6af439720b46083da5bc50d67bce6 guix-build-0ebc6891e216/output/x86_64-w64-mingw32/bitcoin-0ebc6891e216-win64-debug.zip
26f499aafc1f6e7995deab8645c3883cd6b6bb02c4270ec0a7eb1babfad69a39 guix-build-0ebc6891e216/output/x86_64-w64-mingw32/bitcoin-0ebc6891e216-win64-setup-unsigned.exe
5aadaaff0a77aa2559a96bce6d7bda7a48771e48f32c2ad213344f1045586706 guix-build-0ebc6891e216/output/x86_64-w64-mingw32/bitcoin-0ebc6891e216-win64-unsigned.zip |
hebasto
reviewed
Mar 10, 2026
Member
hebasto
left a comment
There was a problem hiding this comment.
My Guix build:
aarch64
1d470d3079f8aca86d223ba0595d927775b97d3397ca1c477dae4f966dbaaef0 guix-build-0ebc6891e216/output/aarch64-linux-gnu/SHA256SUMS.part
2a80a94e3d690ffd6ae6cd4a4819118ff04df28f9ccd84a0fd04134c1553a6c3 guix-build-0ebc6891e216/output/aarch64-linux-gnu/bitcoin-0ebc6891e216-aarch64-linux-gnu-debug.tar.gz
e0886d0ae5a776c4cafa9bab7ee8448629575dbf25578f6f975ba918849cf2b7 guix-build-0ebc6891e216/output/aarch64-linux-gnu/bitcoin-0ebc6891e216-aarch64-linux-gnu.tar.gz
d5cacdb64c0c8e077a0def0f2da0eb16c4339b1c7763e1aeb70405898ac26ba3 guix-build-0ebc6891e216/output/arm-linux-gnueabihf/SHA256SUMS.part
0a2ab75ccfe09763c48a859b195ad22cdf13c9dac413b59230839145ee69fa00 guix-build-0ebc6891e216/output/arm-linux-gnueabihf/bitcoin-0ebc6891e216-arm-linux-gnueabihf-debug.tar.gz
0241029e04ef2511ac338a2164d05ff6215a38141de41452661bf3d657b070b5 guix-build-0ebc6891e216/output/arm-linux-gnueabihf/bitcoin-0ebc6891e216-arm-linux-gnueabihf.tar.gz
e9c6b99fbec816e7e6ba96ec697b96b426a18563b2941573988b9cb4a6862ffb guix-build-0ebc6891e216/output/arm64-apple-darwin/SHA256SUMS.part
b9bc4b8c7769fb3d12530a9c8b55c212fd008f15548224e540278e70169aa503 guix-build-0ebc6891e216/output/arm64-apple-darwin/bitcoin-0ebc6891e216-arm64-apple-darwin-codesigning.tar.gz
4661c10803dc48d87ddd682864323f3969b214736082326a9a4eb0e7b15f076c guix-build-0ebc6891e216/output/arm64-apple-darwin/bitcoin-0ebc6891e216-arm64-apple-darwin-unsigned.tar.gz
c8298f48bf39a0029e401919c4daaa27d82b7868069172bbec63f01ffe24f183 guix-build-0ebc6891e216/output/arm64-apple-darwin/bitcoin-0ebc6891e216-arm64-apple-darwin-unsigned.zip
4111272bda23c91d2ac14df4a0c029d863e77443438509126e970fdfc66d6de9 guix-build-0ebc6891e216/output/dist-archive/bitcoin-0ebc6891e216.tar.gz
a119d4bc7e7cf00e569428b07fbdc41a7ac8e3a91109552f0a9cfd23eb8da51a guix-build-0ebc6891e216/output/powerpc64-linux-gnu/SHA256SUMS.part
8b01f0bde42d8ca63aeccc46bcb9b2f907e8544b10c210eeeb089bba1a0cd0e2 guix-build-0ebc6891e216/output/powerpc64-linux-gnu/bitcoin-0ebc6891e216-powerpc64-linux-gnu-debug.tar.gz
3b9357421f5f614926f0f8bd12e6c13fe9e430a8b0b8101d4418b878ba21813e guix-build-0ebc6891e216/output/powerpc64-linux-gnu/bitcoin-0ebc6891e216-powerpc64-linux-gnu.tar.gz
6491a00ce789a5acc0ce185e8166480f7d8970adde6c8ebbb5c0125e02612daa guix-build-0ebc6891e216/output/riscv64-linux-gnu/SHA256SUMS.part
a2e2bf012a3ef95cb228a0231efc958133c231ee12049148cd8e26775b4ea450 guix-build-0ebc6891e216/output/riscv64-linux-gnu/bitcoin-0ebc6891e216-riscv64-linux-gnu-debug.tar.gz
9f47af47f594f0c7c9ad8098a628402efd4c7db88f8d86343ce41f6ea0d24f9b guix-build-0ebc6891e216/output/riscv64-linux-gnu/bitcoin-0ebc6891e216-riscv64-linux-gnu.tar.gz
98c7ebb8e6caece8df8984d6db1d06a75b59f0ee9cb66bddff7be2aee7335f22 guix-build-0ebc6891e216/output/x86_64-apple-darwin/SHA256SUMS.part
f0e275c09c508f4ed187a6557301685e206509cbf8754cfa73157eb99c7f67af guix-build-0ebc6891e216/output/x86_64-apple-darwin/bitcoin-0ebc6891e216-x86_64-apple-darwin-codesigning.tar.gz
3cac318dee65a877ec1fbf1277ccee315b519443ded37128fd83e8cc85c0863e guix-build-0ebc6891e216/output/x86_64-apple-darwin/bitcoin-0ebc6891e216-x86_64-apple-darwin-unsigned.tar.gz
e6d7572ebb52e809fbff574216c770fc6169285a89b1d34adfe1c21d1a03f9b4 guix-build-0ebc6891e216/output/x86_64-apple-darwin/bitcoin-0ebc6891e216-x86_64-apple-darwin-unsigned.zip
c995afcb34ae9c548db2105a5c3adcb53a3f3c5dbbdd915acad7b630e795ece8 guix-build-0ebc6891e216/output/x86_64-linux-gnu/SHA256SUMS.part
f07ff630cdaf6d936e0163bdc0c8c6f618c690e63adb0a8a519644feef205dc2 guix-build-0ebc6891e216/output/x86_64-linux-gnu/bitcoin-0ebc6891e216-x86_64-linux-gnu-debug.tar.gz
b8544429c410c0b32cef0adcf17cc052ed19e5c6082c9945bc5c739f54bfd4ac guix-build-0ebc6891e216/output/x86_64-linux-gnu/bitcoin-0ebc6891e216-x86_64-linux-gnu.tar.gz
09199389a3b30e14fa960118629662e2f12277e1270572607bbc465bf3c4a5b7 guix-build-0ebc6891e216/output/x86_64-w64-mingw32/SHA256SUMS.part
3823cbb6504cde4d593f58ff354c5a9d77f8222ccf2b882fd1270293380b35de guix-build-0ebc6891e216/output/x86_64-w64-mingw32/bitcoin-0ebc6891e216-win64-codesigning.tar.gz
bbaaf1ca435d2302e9c83b95503f8d588ca6af439720b46083da5bc50d67bce6 guix-build-0ebc6891e216/output/x86_64-w64-mingw32/bitcoin-0ebc6891e216-win64-debug.zip
26f499aafc1f6e7995deab8645c3883cd6b6bb02c4270ec0a7eb1babfad69a39 guix-build-0ebc6891e216/output/x86_64-w64-mingw32/bitcoin-0ebc6891e216-win64-setup-unsigned.exe
5aadaaff0a77aa2559a96bce6d7bda7a48771e48f32c2ad213344f1045586706 guix-build-0ebc6891e216/output/x86_64-w64-mingw32/bitcoin-0ebc6891e216-win64-unsigned.zip
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 11, 2026
Github-Pull: bitcoin#34755 Rebased-From: 168997e
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 11, 2026
Github-Pull: bitcoin#34755 Rebased-From: 0ebc689
Draft
Member
Author
|
Backported to 31.x in #34800. |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 12, 2026
Github-Pull: bitcoin#34755 Rebased-From: 168997e
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 12, 2026
Github-Pull: bitcoin#34755 Rebased-From: 0ebc689
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 followup to #34650, to disable sbom generation.
1 commit to Boost, to cleanup
.natvisfiles that end up in share.