doc: Improve dependencies.md IPC documentation#34706
Merged
fanquake merged 1 commit intobitcoin:masterfrom Mar 4, 2026
Merged
Conversation
Improve dependencies.md to document IPC dependencies better: - Link to native_capnp.mk file not capnp.mk file so it's possible to see what version of Cap'n Proto is being used in release binaries. This is important since bitcoin#31895 dropped the "Version Used" column and the capnp.mk file does not include version number. - Indicate Capn"Proto is used for IPC and link to multiprocess.md documenting the feature. - Link to correct PR requiring Cap'n Proto 0.7.1. Previous link was pointing at PR which required 0.7.0. - Mention libmultiprocess as a dependency even though it is included as a git subtree and can be built as a cmake subproject. Libmultiprocess still needs to be built separately when cross compiling, and is useful to build separately when developing, and is still a depends package. Based on 2cf352f from bitcoin#33623 by willcl-ark which made similar changes in the 29.x branch.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
Member
|
cc @Sjors |
sedited
approved these changes
Mar 4, 2026
Contributor
|
ACK b87a1c2 Checked the links; they seem accurate based on my limited understanding. |
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 4, 2026
Improve dependencies.md to document IPC dependencies better: - Link to native_capnp.mk file not capnp.mk file so it's possible to see what version of Cap'n Proto is being used in release binaries. This is important since bitcoin#31895 dropped the "Version Used" column and the capnp.mk file does not include version number. - Indicate Capn"Proto is used for IPC and link to multiprocess.md documenting the feature. - Link to correct PR requiring Cap'n Proto 0.7.1. Previous link was pointing at PR which required 0.7.0. - Mention libmultiprocess as a dependency even though it is included as a git subtree and can be built as a cmake subproject. Libmultiprocess still needs to be built separately when cross compiling, and is useful to build separately when developing, and is still a depends package. Based on 2cf352f from bitcoin#33623 by willcl-ark which made similar changes in the 29.x branch. Github-Pull: bitcoin#34706 Rebased-From: b87a1c2
Member
|
Backported to 30.x in #34689. |
Merged
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 9, 2026
Improve dependencies.md to document IPC dependencies better: - Link to native_capnp.mk file not capnp.mk file so it's possible to see what version of Cap'n Proto is being used in release binaries. This is important since bitcoin#31895 dropped the "Version Used" column and the capnp.mk file does not include version number. - Indicate Capn"Proto is used for IPC and link to multiprocess.md documenting the feature. - Link to correct PR requiring Cap'n Proto 0.7.1. Previous link was pointing at PR which required 0.7.0. - Mention libmultiprocess as a dependency even though it is included as a git subtree and can be built as a cmake subproject. Libmultiprocess still needs to be built separately when cross compiling, and is useful to build separately when developing, and is still a depends package. Based on 2cf352f from bitcoin#33623 by willcl-ark which made similar changes in the 29.x branch. Github-Pull: bitcoin#34706 Rebased-From: b87a1c2
fanquake
added a commit
that referenced
this pull request
Mar 11, 2026
49a777d doc: update release notes for v30.x (fanquake) 0f9e08f doc: update build guides pre v31 (fanquake) 597ac36 doc: Fix `fee` field in `getblock` RPC result (nervana21) 47ed306 depends: Allow building Qt packages after interruption (Hennadii Stepanov) d221d1c psbt: validate pubkeys in MuSig2 pubnonce/partial sig deserialization (tboy1337) e1210ac doc: Improve dependencies.md IPC documentation (Ryan Ofsky) c17a5cd test: Add missing timeout_factor to zmq socket (MarcoFalke) 3042509 netif: fix compilation warning in QueryDefaultGatewayImpl() (MarcoFalke) 475a5b0 refactor: Use static_cast<decltype(...)> to suppress integer sanitizer warning (MarcoFalke) 7220ee3 util: Fix UB in SetStdinEcho when ENOTTY (MarcoFalke) Pull request description: Backports: * #34093 * #34219 * #34597 * #34690 * #34702 * #34706 * #34713 * #34789 ACKs for top commit: marcofleon: ACK 49a777d Tree-SHA512: b4ce54860b7306b22de75bb093ad574110875253e4ea3ca96a736809c8291dea1144a617c8791f36618d8e367022709ba5cf84ca0e450ef6d76394ab80f22e2f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve dependencies.md to document IPC dependencies better (preview). Specific changes are listed in the commit message.
This PR is based on #33623 by willcl-ark which made similar changes in the 29.x branch. This PR could also be backported to 30.x (it merges cleanly, and master and 30.x both have the same version requirements).