test: Add missing timeout_factor to zmq socket#34690
Merged
achow101 merged 1 commit intobitcoin:masterfrom Feb 27, 2026
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
Contributor
|
code review ACK fa48f8c Converting from seconds to millis (pre-existing behavior), scaling by timeout factor meant for heavier CI (not sure if sanitizers are the reason here or just slow machines), and casting the result back from float. |
Member
|
ACK fa48f8c |
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 2, 2026
Github-Pull: bitcoin#34690 Rebased-From: fa48f8c
Merged
Member
|
Backported to 30.x in #34689. |
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 9, 2026
Github-Pull: bitcoin#34690 Rebased-From: fa48f8c
fanquake
added a commit
that referenced
this pull request
Mar 11, 2026
49a777d doc: update release notes for v30.x (fanquake) 0f9e08f doc: update build guides pre v31 (fanquake) 597ac36 doc: Fix `fee` field in `getblock` RPC result (nervana21) 47ed306 depends: Allow building Qt packages after interruption (Hennadii Stepanov) d221d1c psbt: validate pubkeys in MuSig2 pubnonce/partial sig deserialization (tboy1337) e1210ac doc: Improve dependencies.md IPC documentation (Ryan Ofsky) c17a5cd test: Add missing timeout_factor to zmq socket (MarcoFalke) 3042509 netif: fix compilation warning in QueryDefaultGatewayImpl() (MarcoFalke) 475a5b0 refactor: Use static_cast<decltype(...)> to suppress integer sanitizer warning (MarcoFalke) 7220ee3 util: Fix UB in SetStdinEcho when ENOTTY (MarcoFalke) Pull request description: Backports: * #34093 * #34219 * #34597 * #34690 * #34702 * #34706 * #34713 * #34789 ACKs for top commit: marcofleon: ACK 49a777d Tree-SHA512: b4ce54860b7306b22de75bb093ad574110875253e4ea3ca96a736809c8291dea1144a617c8791f36618d8e367022709ba5cf84ca0e450ef6d76394ab80f22e2f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34189
Otherwise, the test may intermittently fail on slow CI systems that have
--timeout-factor=properly set.It can be tested by running
./bld-cmake/test/functional/interface_zmq.py --timeout-factor=10with this diff:Before this pull: Test fails with
zmq.error.Again: Resource temporarily unavailableAfter this pull: Test passes