qt: GUI for --disable-wallet compiles and -disablewallet mode #3392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be a nice change :). |
Member
Author
|
Thanks :D |
Member
|
Looks good, didn't test. |
|
Should we still allow (because of license stuff) to show about Qt and also our own about (which contains OpenSSL license info)? Also the manu bar to exit the program would be nice perhaps. |
Member
Author
|
The About options and Exit should still be available in the menu? Or did the rebase remove those? |
|
I just looked at the screenshot, which is obsolete then perhaps. |
Member
Author
|
It's pretty much up to date. It doesn't show the menu because ubuntu displays a global menu instead of a per-window menu. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/8a1f6961820a306b11bca18f85b8c5faafb5192e for binaries and test log. |
To make sure the right slots are generated, MOC needs -DHAVE_CONFIG_H and correct include path to include bitcoin-config.h.
There is not much in the GUI to be done without wallet, though it's possible to change options, watch the sync process, and use the debug console. So embed the debug console in the main window.
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Oct 5, 2018
jfhk
pushed a commit
to jfhk/bitcoin
that referenced
this pull request
Nov 14, 2018
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Nov 26, 2018
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Dec 24, 2018
Ref bitcoin#3392 Github-Pull: bitcoin#14383 Rebased-From: 36323e2
promag
pushed a commit
to promag/bitcoin
that referenced
this pull request
Dec 30, 2018
Ref bitcoin#3392 Github-Pull: bitcoin#14383 Rebased-From: 36323e2
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Apr 8, 2020
Backports 0.16 pr14
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 28, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#14383 | PR14383]] and [[bitcoin/bitcoin#15023 | PR15023]] PR 14383 description: > There is a Debug window leftover in the system tray icon menu after [[bitcoin/bitcoin#3392 | PR3392]] merging. > This PR makes both the app menu and the systray icon menu consistent. PR15023 description: > [[bitcoin/bitcoin#14383 | PR14383]] moved the debug window's menu position, to make it conditional on wallet mode. The rationale given was to match the behaviour of the 'Help' menu. > > [[bitcoin/bitcoin#14573 | PR14573]] replaced the 'Help' menu's conditional debug window with an unconditional list of items in the new 'Window' menu. > > This PR reverts the no-longer-applicable part of #14383, putting the debug window back on the tray menu unconditionally, and in the position it previously had. Note: PR14573 was backported in D7892 Test Plan: `ninja && src/qt/bitcoin-qt -disablewallet` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Subscribers: deadalnix, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8146
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Apr 14, 2021
Summary: This is a backport of Core [[bitcoin/bitcoin#14383 | PR14383]] and [[bitcoin/bitcoin#15023 | PR15023]] PR 14383 description: > There is a Debug window leftover in the system tray icon menu after [[bitcoin/bitcoin#3392 | PR3392]] merging. > This PR makes both the app menu and the systray icon menu consistent. PR15023 description: > [[bitcoin/bitcoin#14383 | PR14383]] moved the debug window's menu position, to make it conditional on wallet mode. The rationale given was to match the behaviour of the 'Help' menu. > > [[bitcoin/bitcoin#14573 | PR14573]] replaced the 'Help' menu's conditional debug window with an unconditional list of items in the new 'Window' menu. > > This PR reverts the no-longer-applicable part of #14383, putting the debug window back on the tray menu unconditionally, and in the position it previously had. Note: PR14573 was backported in D7892 Test Plan: `ninja && src/qt/bitcoin-qt -disablewallet` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Subscribers: deadalnix, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8146
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is not much in the GUI to be done without wallet, but it's possible to change options, watch the sync process, and use the debug console.
So embed the debug console in the main window.