GUI: Restore RPC Console to non-wallet tray icon menu #15023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Maybe also split like window menu? |
Member
Author
|
Dunno, that might be a bit extreme for merely a systray menu. |
Contributor
|
Are there constraints/guidelines regarding systray menu? |
Member
Dock Menus (by Apple) could be applicable, IMO. UPDATE:
|
Contributor
This. |
Contributor
|
Tested ACK f33efa8 - the debug window is also accessible from the menu (though directly the subpages which counts IMO). Unrelated to this PR: the label "Debug Window" is probably outdated and confusing. |
Contributor
Agree! |
jonasschnelli
added a commit
that referenced
this pull request
Oct 10, 2019
f33efa8 GUI: Restore RPC Console to non-wallet tray icon menu (Luke Dashjr) Pull request description: #14383 moved the debug window's menu position, to make it conditional on wallet mode. The rationale given was to match the behaviour of the 'Help' menu. #14573 replaced the 'Help' menu's conditional debug window with an unconditional list of items in the new 'Window' menu. This PR reverts the no-longer-applicable part of #14383, putting the debug window back on the tray menu unconditionally, and in the position it previously had. ACKs for top commit: jonasschnelli: Tested ACK f33efa8 - the debug window is also accessible from the menu (though directly the subpages which counts IMO). Tree-SHA512: c04a588fed37a8c31cb413baaa346e3c1c18724f9b40d64b8528c517f65290930d577bccf0a794180e968e84d3c52e9fa3fdc8a40bbc5fe3418eaddd73481271
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 11, 2019
… menu f33efa8 GUI: Restore RPC Console to non-wallet tray icon menu (Luke Dashjr) Pull request description: bitcoin#14383 moved the debug window's menu position, to make it conditional on wallet mode. The rationale given was to match the behaviour of the 'Help' menu. bitcoin#14573 replaced the 'Help' menu's conditional debug window with an unconditional list of items in the new 'Window' menu. This PR reverts the no-longer-applicable part of bitcoin#14383, putting the debug window back on the tray menu unconditionally, and in the position it previously had. ACKs for top commit: jonasschnelli: Tested ACK f33efa8 - the debug window is also accessible from the menu (though directly the subpages which counts IMO). Tree-SHA512: c04a588fed37a8c31cb413baaa346e3c1c18724f9b40d64b8528c517f65290930d577bccf0a794180e968e84d3c52e9fa3fdc8a40bbc5fe3418eaddd73481271
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Nov 17, 2019
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Nov 17, 2019
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 28, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#14383 | PR14383]] and [[bitcoin/bitcoin#15023 | PR15023]] PR 14383 description: > There is a Debug window leftover in the system tray icon menu after [[bitcoin/bitcoin#3392 | PR3392]] merging. > This PR makes both the app menu and the systray icon menu consistent. PR15023 description: > [[bitcoin/bitcoin#14383 | PR14383]] moved the debug window's menu position, to make it conditional on wallet mode. The rationale given was to match the behaviour of the 'Help' menu. > > [[bitcoin/bitcoin#14573 | PR14573]] replaced the 'Help' menu's conditional debug window with an unconditional list of items in the new 'Window' menu. > > This PR reverts the no-longer-applicable part of #14383, putting the debug window back on the tray menu unconditionally, and in the position it previously had. Note: PR14573 was backported in D7892 Test Plan: `ninja && src/qt/bitcoin-qt -disablewallet` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Subscribers: deadalnix, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8146
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Apr 14, 2021
Summary: This is a backport of Core [[bitcoin/bitcoin#14383 | PR14383]] and [[bitcoin/bitcoin#15023 | PR15023]] PR 14383 description: > There is a Debug window leftover in the system tray icon menu after [[bitcoin/bitcoin#3392 | PR3392]] merging. > This PR makes both the app menu and the systray icon menu consistent. PR15023 description: > [[bitcoin/bitcoin#14383 | PR14383]] moved the debug window's menu position, to make it conditional on wallet mode. The rationale given was to match the behaviour of the 'Help' menu. > > [[bitcoin/bitcoin#14573 | PR14573]] replaced the 'Help' menu's conditional debug window with an unconditional list of items in the new 'Window' menu. > > This PR reverts the no-longer-applicable part of #14383, putting the debug window back on the tray menu unconditionally, and in the position it previously had. Note: PR14573 was backported in D7892 Test Plan: `ninja && src/qt/bitcoin-qt -disablewallet` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Subscribers: deadalnix, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8146
linuxsh2
pushed a commit
to linuxsh2/dash
that referenced
this pull request
Jul 30, 2021
… menu f33efa8 GUI: Restore RPC Console to non-wallet tray icon menu (Luke Dashjr) Pull request description: bitcoin#14383 moved the debug window's menu position, to make it conditional on wallet mode. The rationale given was to match the behaviour of the 'Help' menu. bitcoin#14573 replaced the 'Help' menu's conditional debug window with an unconditional list of items in the new 'Window' menu. This PR reverts the no-longer-applicable part of bitcoin#14383, putting the debug window back on the tray menu unconditionally, and in the position it previously had. ACKs for top commit: jonasschnelli: Tested ACK f33efa8 - the debug window is also accessible from the menu (though directly the subpages which counts IMO). Tree-SHA512: c04a588fed37a8c31cb413baaa346e3c1c18724f9b40d64b8528c517f65290930d577bccf0a794180e968e84d3c52e9fa3fdc8a40bbc5fe3418eaddd73481271
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14383 moved the debug window's menu position, to make it conditional on wallet mode. The rationale given was to match the behaviour of the 'Help' menu.
#14573 replaced the 'Help' menu's conditional debug window with an unconditional list of items in the new 'Window' menu.
This PR reverts the no-longer-applicable part of #14383, putting the debug window back on the tray menu unconditionally, and in the position it previously had.