Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Nov 25, 2023

Last time we updated dependency packages used when compiling with MSVC in #26891. Then we switched to specifying the builtin-baseline in the vcpkg.json manifest file, which made checking out the entire vcpkg repository to a specific commit or tag unneeded.

This PR updates the manifest baseline from 2023.01.09 to 2023.08.09:

  • berkeleydb: 4.8.30#8 --> 4.8.30#9
  • boost: 1.81.0 --> 1.82.0#2
  • sqlite3: 3.40.0#1 --> 3.42.0#1
  • zeromq: 4.3.4#6 --> 2023-06-20#1

The most recent https://github.com/microsoft/vcpkg/releases/tag/2023.11.20 tag is still unavailable in the vcpkg installation in the current GHA Windows image (the head commit is microsoft/vcpkg@2b14b60 only).

The other https://github.com/microsoft/vcpkg/releases/tag/2023.10.19 tag introduces a warning C4297 in the Boost.Process 1.83 that is fixed in the upcoming version 1.84.

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 25, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Dependency changes (2023.01.09 --> 2023.08.09):
- berkeleydb: 4.8.30#8 --> 4.8.30#9
- boost: 1.81.0 --> 1.82.0#2
- sqlite3: 3.40.0#1 --> 3.42.0#1
- zeromq: 4.3.4#6 --> 2023-06-20#1
Compilation now succeeds only by coincidence, as the `boost-date-time`
package is installed as a dependency of the `boost-process` one.
@hebasto hebasto marked this pull request as draft November 25, 2023 18:35
@hebasto hebasto marked this pull request as ready for review November 25, 2023 19:04
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6d05c4f

@fanquake fanquake merged commit c7f0e97 into bitcoin:master Nov 30, 2023
@hebasto hebasto deleted the 231125-vcpkg branch November 30, 2023 16:22
fanquake added a commit that referenced this pull request Nov 5, 2024
f6577b7 build, msvc: Update vcpkg manifest baseline (Hennadii Stepanov)
16e1601 build, msvc: Document `libevent` version pinning (Hennadii Stepanov)
ec47cd2 build, msvc: Drop no longer needed `liblzma` version pinning (Hennadii Stepanov)
9a0734d build, msvc: Reorder keys in `vcpkg.json` (Hennadii Stepanov)

Pull request description:

  This PR updates the vcpkg manifest baseline from the [2023.08.09 Release ](https://github.com/microsoft/vcpkg/releases/tag/2023.08.09) to the [2024.09.30 Release](https://github.com/microsoft/vcpkg/releases/tag/2024.09.30), with the following package changes:
  - `boost`: 1.82.0#2 --> 1.85.0#1,2
  - `qt5`: 5.15.10#5 -> 5.15.15
  - `sqlite3`: 3.42.0#1 --> 3.46.1
  - `zeromq`: 2023-06-20#1 --> 4.3.5#2

  The previous update was made in #28938.

  For additional minor improvements, please refer to the commit messages.

ACKs for top commit:
  fanquake:
    ACK f6577b7

Tree-SHA512: bfd6f995d97cd3222573ac1c3626c13ee68cf3e2de344869a2d91775090d60f63ef2b17d9a59eba46620eedd51d6787aebe3aeed1189ec55379211a186c21b4e
@bitcoin bitcoin locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants