Skip to content

ci: Update "Win64 native" task #26891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maflcko merged 2 commits into from
Jan 16, 2023
Merged

ci: Update "Win64 native" task #26891

maflcko merged 2 commits into from
Jan 16, 2023

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Jan 13, 2023

This PR bumps vcpkg and ccache versions.

Dependency changes in vcpkg (2022.09.27 - 2023.01.09):

  • boost 1.80.0#0 -> 1.81.0#0
  • libevent 2.1.12#6 -> libevent 2.1.12#7
  • sqlite3 3.39.2#0 -> 3.40.0#1

Also see #26866 (comment).

@hebasto
ci: Bump vcpkg to the latest version 2023.01.09
1039ed4 
Dependency changes (2022.09.27 - 2023.01.09):
 - boost 1.80.0#0 -> 1.81.0#0
 - libevent 2.1.12#6 -> libevent 2.1.12#7
 - sqlite3 3.39.2#0 -> 3.40.0#1
@hebasto
ci: Bump ccache version to the latest 4.7.4 in "Win64 native" task
46c31ee
@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 13, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@DrahtBot DrahtBot added the Tests label Jan 13, 2023
@maflcko maflcko merged commit 08d2a3a into bitcoin:master Jan 16, 2023
@hebasto hebasto deleted the 230113-vcpkg branch January 16, 2023 10:29
maflcko
maflcko reviewed Jan 16, 2023
View reviewed changes
.cirrus.yml
install_tools_script:
- choco install --yes --no-progress ccache --version=4.6.1
- choco install --yes --no-progress ccache --version=4.7.4
- choco install --yes --no-progress python3 --version=3.9.6
Copy link
Member

@maflcko maflcko Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, realized after merge: I guess it should be fine to bump this as well, so that everything is still pinned but bumped to the latest version. (And add a comment that bumping to the latest in this file is fine?)

Finally, a two line patch could be squashed into one commit, but no big deal.

@hebasto
Copy link
Member Author

hebasto commented May 21, 2023

FWIW, the recent ccache 4.8.1 seems broken. Note the cacheable calls ratio:

Cacheable calls:   264 / 617 (42.79%)
  Hits:            264 / 264 (100.0%)
    Direct:        264 / 264 (100.0%)
    Preprocessed:    0 / 264 ( 0.00%)
  Misses:            0 / 264 ( 0.00%)
Uncacheable calls: 353 / 617 (57.21%)
Local storage:
  Cache size (GB): 0.2 / 0.2 (99.87%)
  Hits:            264 / 264 (100.0%)
  Misses:            0 / 264 ( 0.00%)

@hebasto
Copy link
Member Author

hebasto commented Jul 13, 2023

FWIW, the recent ccache 4.8.1 seems broken. Note the cacheable calls ratio:

I found the reason that ccache >= 4.8 is not working as expected. We need to have <ObjectFileName>$(IntDir)%(FileName).obj</ObjectFileName> in every project file.

However, in the light of upcoming CMake-based build system, I see no reasons to change our current build_msvc directory.

@hebasto hebasto mentioned this pull request Nov 25, 2023
Merged
fanquake added a commit to bitcoin-core/gui that referenced this pull request Nov 30, 2023
@fanquake
Merge bitcoin/bitcoin#28938: msvc: Update vcpkg manifest
c7f0e97 
6d05c4f msvc: Specify `boost-date-time` package explicitly (Hennadii Stepanov)
1f97e51 msvc: Update vcpkg manifest baseline up to "2023.08.09 Release" (Hennadii Stepanov)
2d2ef2f msvc: No need to specify the default feature for `libevent` package (Hennadii Stepanov)

Pull request description:

  Last time we updated dependency packages used when compiling with MSVC in bitcoin/bitcoin#26891. Then we [switched](bitcoin/bitcoin#27335) to specifying the `builtin-baseline` in the `vcpkg.json` manifest file, which made checking out the entire vcpkg repository to a specific commit or tag unneeded.

  This PR updates the manifest baseline from [2023.01.09](https://github.com/microsoft/vcpkg/releases/tag/2023.01.09) to [2023.08.09](https://github.com/microsoft/vcpkg/releases/tag/2023.08.09):
  - berkeleydb: 4.8.30#8 --> 4.8.30#9
  - boost: 1.81.0 --> 1.82.0#2
  - sqlite3: 3.40.0#1 --> 3.42.0#1
  - zeromq: 4.3.4#6 --> 2023-06-20#1

  The most recent https://github.com/microsoft/vcpkg/releases/tag/2023.11.20 tag is still unavailable in the vcpkg installation in the current GHA Windows image (the head commit is microsoft/vcpkg@2b14b60 only).

  The other https://github.com/microsoft/vcpkg/releases/tag/2023.10.19 tag [introduces](boostorg/process@0c42a58) a warning C4297 in the Boost.Process 1.83 that is [fixed](boostorg/process#340) in the upcoming version 1.84.

ACKs for top commit:
  fanquake:
    ACK 6d05c4f

Tree-SHA512: c71c46c13ad5a6d39ae72982b7765f690e7391092e4983887a53dceeee507c8fc256e887351bbe35c051bf88d2babeb283e17a2588ee86ec9020c4ba426bfcd7
@bitcoin bitcoin locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@maflcko maflcko maflcko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Tests Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hebasto @DrahtBot @maflcko