guix: Silence getent(1) invocation, doc fixups
#22511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryRuane
approved these changes
Jul 21, 2021
| ################ | ||
|
|
||
| if ! getent services http https ftp; then | ||
| if ! getent services http https ftp > /dev/null 2>&1; then |
Contributor
There was a problem hiding this comment.
utACK 3c4d2c4
Suggested change
| if ! getent services http https ftp > /dev/null 2>&1; then | |
| if ! getent services http https ftp &>/dev/null; then |
Member
|
ACK 3c4d2c4 thanks for addressing this |
theStack
approved these changes
Jul 21, 2021
Contributor
theStack
left a comment
There was a problem hiding this comment.
ACK 3c4d2c4
Didn't run the script but verified the behaviour in the shell:
$ getent services http https ftp; echo $?
http 80/tcp www
https 443/tcp
ftp 21/tcp
0
$ getent services http https ftp unknown-service; echo $?
http 80/tcp www
https 443/tcp
ftp 21/tcp
2
PR branch:
$ getent services http https ftp > /dev/null 2>&1; echo $?
0
$ getent services http https ftp unknown-service > /dev/null 2>&1; echo $?
2
Contributor
Author
|
Maintainers: would you mind if I tacked on a few README changes to this PR? I'm thinking of addressing the posthumous comments here: |
Member
|
@dongcarl sgtm |
LarryRuane
reviewed
Jul 22, 2021
Contributor
LarryRuane
left a comment
There was a problem hiding this comment.
utACK f0e00d0173087b29e0a1045a4073a292c55bd954
As long as you're changing INSTALL.md, if you retouch (I'll reack right away), there are a couple other typos:
- s/has a known problems/has known problems/
- s/erratas/errata/
Member
|
See #22527 for more tidy-ups to pull into this PR? The title of this PR could be changed, as it wasn't clear to me that these were being addressed. |
Member
|
utACK f0e00d0173087b29e0a1045a4073a292c55bd954. The current output is rather confusing. |
f0e00d0 to
a884a1e
Compare
getent(1) invocationgetent(1) invocation, doc fixups
fanquake
approved these changes
Jul 23, 2021
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jul 23, 2021
Github-Pull: bitcoin#22511 Rebased-From: 3c4d2c4
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jul 23, 2021
Github-Pull: bitcoin#22511 Rebased-From: a884a1e
Merged
Member
|
Backported in #22534 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 23, 2021
a884a1e guix/INSTALL: Misc fixups (Carl Dong) 3c4d2c4 guix: Silence getent(1) invocation (Carl Dong) Pull request description: Otherwise the `getent(1)` checks will print out the default http, https, and ftp ports, making it seem like something is being spawned that is listening on those ports, which is not the case. ACKs for top commit: fanquake: ACK a884a1e Tree-SHA512: 7706a98fe5f2bcd766fd3a16bfffab899ec45e80d72c485b7bed2a83d2024eddbb44ae4a77e2352e308740ca203c163421a11a5a2327fa94d2032ecceef4d63f
laanwj
added a commit
that referenced
this pull request
Aug 2, 2021
739d190 doc: add info to i2p.md about IBD time and multiple networks (Jon Atack) cc8838c contrib, p2p: update I2P hardcoded seeds (Jon Atack) cd57bb1 guix: Ensure EPOCH_SOURCE_DATE does not include GPG information (Andrew Chow) 219900a guix: Remove extra \r from all.SHA256SUMS line ending (Andrew Chow) 38d18c0 guix, doc: Add a note that codesigners need to rebuild after tagging (Andrew Chow) aa9b6ab guix: Allow changing the base manifest in guix-verify (Andrew Chow) 056e47d guix: Make all.SHA256SUMS rather than codesigned.SHA256SUMS (Andrew Chow) 8f1e3b3 script, doc: guix touchups (jonatack) 3bbfc1b Updated Readme, Corrected the codesign typo (h) 34f9f88 guix/build: Remove vestigial SKIPATTEST.TAG (Carl Dong) 9e52a30 guix/INSTALL: Misc fixups (Carl Dong) 45e0f3d guix: Silence getent(1) invocation (Carl Dong) Pull request description: Currently backports #22511. We can collect up further backports and merge prior to rc2. ACKs for top commit: laanwj: ACK 739d190 Tree-SHA512: 8fc795ee56b7757ff405636a2811bd606ea33ba1160f3f1ea42e0e1478ce8211bb60bf7b16a673b932db40a24b76d47c54e703bf2775d3b9385d9b080183b433
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the
getent(1)checks will print out the default http, https, and ftp ports, making it seem like something is being spawned that is listening on those ports, which is not the case.