Skip to content

Conversation

@jonatack
Copy link
Member

No description provided.

@fanquake
Copy link
Member

A bunch of these are being done in #22511.

@jonatack
Copy link
Member Author

jonatack commented Jul 22, 2021

Most of them aren't.

@fanquake
Copy link
Member

Probably easiest to point out the few additional typos in that PR. Then we can just backport 2 commits.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK dced8b5

@hebasto
Copy link
Member

hebasto commented Jul 22, 2021

Probably easiest to point out the few additional typos in that PR. Then we can just backport 2 commits.

Agree. Also #22511 (comment)

@jonatack
Copy link
Member Author

Most of these suggestions aren't in the current version of #22511 and that PR is about something else. But ok 🤷‍♂️

@jonatack jonatack closed this Jul 22, 2021
@fanquake
Copy link
Member

There's enough overlap to combine them into one, and some of the changes here were already pointed out in a comment in that PR. Some of the changes here are also not correct. i.e the sig files are called noncodesigned.SHA256SUMS, so updating the error messages to call them non-codesigned.SHA256SUMS is not right.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants