Skip to content

Conversation

@Sjors
Copy link
Member

@Sjors Sjors commented May 4, 2020

Thanks to #18774's adjust_bitcoin_conf_for_pre_17 we can now test backwards compatibility for v0.16.3, both for sync and loading a recent wallet.

This PR bumps v0.19.0.1 to v0.19.1.

I also made the version list consistent for the contrib/devtools/previous_release.sh instruction, between both tests.

@fanquake fanquake added the Tests label May 4, 2020
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9226c7236496ae92bfb472470c65b95caa95ed55

@Sjors Sjors force-pushed the 2020/05/backwards_compat branch from 9226c72 to 94d57bd Compare May 4, 2020 19:27
@maflcko
Copy link
Member

maflcko commented May 4, 2020

ACK 94d57bd2917a5c9111bd21ac27b829a25ed05fee

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, please only put this in the config that actually needs the releases

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

Co-Authored-By: MarcoFalke <falke.marco@gmail.com>
@Sjors Sjors force-pushed the 2020/05/backwards_compat branch from 94d57bd to d135c29 Compare May 8, 2020 14:13
@maflcko
Copy link
Member

maflcko commented May 8, 2020

ACK d135c29

@maflcko maflcko merged commit 3930014 into bitcoin:master May 8, 2020
@Sjors Sjors deleted the 2020/05/backwards_compat branch May 8, 2020 16:09
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 12, 2020
…0.19.0.1 to v0.19.1

d135c29 [ci] make list of previous releases to download a setting (Sjors Provoost)
9c246b8 [test] backwards compatibility: bump v0.19.0.1 to v0.19.1 (Sjors Provoost)
89a28e0 [test] add v0.16.3 backwards compatibility test (Sjors Provoost)

Pull request description:

  Thanks to bitcoin#18774's `adjust_bitcoin_conf_for_pre_17` we can now test backwards compatibility for v0.16.3, both for sync and loading a recent wallet.

  This PR bumps v0.19.0.1 to v0.19.1.

  I also made the version list consistent for the `contrib/devtools/previous_release.sh` instruction, between both tests.

ACKs for top commit:
  MarcoFalke:
    ACK d135c29

Tree-SHA512: 5ff137a7a934237fa220f1c2807ce9abeeb75929266558bf3e4045bec7dfcd0a8747fa74d700065c568330b18badf58c60c308eb13d1eed444d4bbfe6decc48b
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants