-
Notifications
You must be signed in to change notification settings - Fork 38.7k
Add v0.16.3 backwards compatibility test, bump v0.19.0.1 to v0.19.1 #18864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
maflcko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9226c7236496ae92bfb472470c65b95caa95ed55
9226c72 to
94d57bd
Compare
|
ACK 94d57bd2917a5c9111bd21ac27b829a25ed05fee |
ci/test/00_setup_env.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, please only put this in the config that actually needs the releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point
Co-Authored-By: MarcoFalke <falke.marco@gmail.com>
94d57bd to
d135c29
Compare
|
ACK d135c29 |
…0.19.0.1 to v0.19.1 d135c29 [ci] make list of previous releases to download a setting (Sjors Provoost) 9c246b8 [test] backwards compatibility: bump v0.19.0.1 to v0.19.1 (Sjors Provoost) 89a28e0 [test] add v0.16.3 backwards compatibility test (Sjors Provoost) Pull request description: Thanks to bitcoin#18774's `adjust_bitcoin_conf_for_pre_17` we can now test backwards compatibility for v0.16.3, both for sync and loading a recent wallet. This PR bumps v0.19.0.1 to v0.19.1. I also made the version list consistent for the `contrib/devtools/previous_release.sh` instruction, between both tests. ACKs for top commit: MarcoFalke: ACK d135c29 Tree-SHA512: 5ff137a7a934237fa220f1c2807ce9abeeb75929266558bf3e4045bec7dfcd0a8747fa74d700065c568330b18badf58c60c308eb13d1eed444d4bbfe6decc48b
Thanks to #18774's
adjust_bitcoin_conf_for_pre_17we can now test backwards compatibility for v0.16.3, both for sync and loading a recent wallet.This PR bumps v0.19.0.1 to v0.19.1.
I also made the version list consistent for the
contrib/devtools/previous_release.shinstruction, between both tests.