test: added test for upgradewallet RPC #18774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Apr 26, 2020
maflcko
reviewed
Apr 26, 2020
Contributor
Author
|
@MarcoFalke |
maflcko
reviewed
Apr 26, 2020
Member
|
You'll also need to adjust ci/test/05_before_script.sh |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
This was referenced Apr 27, 2020
maflcko
reviewed
Apr 27, 2020
maflcko
reviewed
Apr 27, 2020
maflcko
reviewed
Apr 27, 2020
maflcko
reviewed
Apr 27, 2020
maflcko
approved these changes
Apr 27, 2020
achow101
reviewed
Apr 28, 2020
Member
achow101
left a comment
There was a problem hiding this comment.
We should be be testing the specific version upgrades too, but this is a good place to start with. Those can be added in later.
ACK 84267045efbfbe2a035e7f34851f1b3bc9964be8
maflcko
approved these changes
Apr 29, 2020
maflcko
approved these changes
Apr 29, 2020
Member
maflcko
left a comment
There was a problem hiding this comment.
ACK. Will be merged as soon as travis is green
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 8, 2020
…0.19.0.1 to v0.19.1 d135c29 [ci] make list of previous releases to download a setting (Sjors Provoost) 9c246b8 [test] backwards compatibility: bump v0.19.0.1 to v0.19.1 (Sjors Provoost) 89a28e0 [test] add v0.16.3 backwards compatibility test (Sjors Provoost) Pull request description: Thanks to bitcoin#18774's `adjust_bitcoin_conf_for_pre_17` we can now test backwards compatibility for v0.16.3, both for sync and loading a recent wallet. This PR bumps v0.19.0.1 to v0.19.1. I also made the version list consistent for the `contrib/devtools/previous_release.sh` instruction, between both tests. ACKs for top commit: MarcoFalke: ACK d135c29 Tree-SHA512: 5ff137a7a934237fa220f1c2807ce9abeeb75929266558bf3e4045bec7dfcd0a8747fa74d700065c568330b18badf58c60c308eb13d1eed444d4bbfe6decc48b
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 12, 2020
…0.19.0.1 to v0.19.1 d135c29 [ci] make list of previous releases to download a setting (Sjors Provoost) 9c246b8 [test] backwards compatibility: bump v0.19.0.1 to v0.19.1 (Sjors Provoost) 89a28e0 [test] add v0.16.3 backwards compatibility test (Sjors Provoost) Pull request description: Thanks to bitcoin#18774's `adjust_bitcoin_conf_for_pre_17` we can now test backwards compatibility for v0.16.3, both for sync and loading a recent wallet. This PR bumps v0.19.0.1 to v0.19.1. I also made the version list consistent for the `contrib/devtools/previous_release.sh` instruction, between both tests. ACKs for top commit: MarcoFalke: ACK d135c29 Tree-SHA512: 5ff137a7a934237fa220f1c2807ce9abeeb75929266558bf3e4045bec7dfcd0a8747fa74d700065c568330b18badf58c60c308eb13d1eed444d4bbfe6decc48b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the newly merged upgradewallet RPC.
Additionally, it expands
test_framework/util.pyby adding the functionadjust_bitcoin_conf_for_pre_17to support nodes that don't parse configuration sections.This test uses two older node versions, v0.15.2 and v0.16.3, to create older wallet versions to be used by
upgradewallet.Fixes #18767