0.17: GUI Backports #14123 #14133 #14383 #14597 #15065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github-Pull: bitcoin#14133 Rebased-From: ee3a494
Ref bitcoin#3392 Github-Pull: bitcoin#14383 Rebased-From: 36323e2
Qt `setWindowIcon()` does this work. Github-Pull: bitcoin#14597 Rebased-From: 53bb6be
This moves the Dock icon click reaction code to the common place and allows some cleanup in obj_c code. According to the Apple's docs `class_replaceMethod` behaves as `class_addMethod`, if the method identified by name does not yet exist; or as `method_setImplementation`, if it does exist. Github-Pull: bitcoin#14597 Rebased-From: 2464925
Qt `setAsDockMenu()` does this work. Github-Pull: bitcoin#14597 Rebased-From: 6b1d297
Github-Pull: bitcoin#14123 Rebased-From: 5796671
Github-Pull: bitcoin#14123 Rebased-From: 6fc21ac
Github-Pull: bitcoin#14123 Rebased-From: 0a656f8
Member
|
Tested on macOS 10.14.2 (qt 5.12.0) on top of 16521ce. Checked that the dock icon appears correctly. |
Contributor
Author
|
Thanks @fanquake, I think that's it. |
Member
|
utACK 27beb83 |
Member
|
tACK 27beb83 (Linux Mint 19.2, macOS 10.13.6). |
laanwj
added a commit
that referenced
this pull request
Jan 3, 2019
27beb83 qt: All tray menu actions call showNormalIfMinimized (João Barbosa) c470bbd qt: Use GUIUtil::bringToFront where possible (João Barbosa) ac73c7d qt: Add GUIUtil::bringToFront (João Barbosa) 0c2fb87 Remove obj_c for macOS Dock icon menu (Hennadii Stepanov) 9034714 Use Qt signal for macOS Dock icon click event (Hennadii Stepanov) 4d4bc37 Remove obj_c for macOS Dock icon setting (Hennadii Stepanov) d2ed162 Clean systray icon menu for -disablewallet mode (Hennadii Stepanov) 298dc15 gui: Favor macOS show / hide action in dock menu (João Barbosa) Pull request description: Backport #14123 #14133 #14383 and #14597 to 0.17 branch to fix #13606 (comment). Tree-SHA512: 543c80e7e2130870e801e0c9a69b06b9eea27c288478fc5dddeb662f7f3ec5b56b30916e5a9a629fced3fffcb8be77e2cd155e75cfd0a4392299add9730840f4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #14123 #14133 #14383 and #14597 to 0.17 branch to fix #13606 (comment).