qt: Fix minimized window bug on Linux #14594
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Given that this is touching the same function, and fixing similar behaviour to #14222, I'd combine this into that PR. Please keep the two commits seperate though, if these fixing different bugs etc. |
4cd3ea1 to
89787c2
Compare
|
Rebased after #14123 merging. @promag @jonasschnelli |
src/qt/guiutil.cpp
Outdated
There was a problem hiding this comment.
Does calling isObscured() directly after showNormal() make sense or should it hit back the the runloop first?
89787c2 to
40d3f19
Compare
|
@jonasschnelli Would you mind re-reviewing? |
|
utACK 40d3f19d20040ff1e0b2754fd083d0bb269c2fb5 |
|
utACK 40d3f19 |
src/qt/bitcoingui.cpp
Outdated
There was a problem hiding this comment.
We might want to use a unique_ptr and RAII here?
|
utACK (modulus nit) @hebasto Thanks a lot for doing a thorough investigation here and not piling on more hacks that seem to do the job. |
On some Linux systems the minimized to the taskbar (iconified) main window cannot be restored properly using actions from the systray icon menu when QSystemTrayIcon::contextMenu() is a child of the main window.
40d3f19 to
a88640e
Compare
|
@laanwj Thank you for your review.
Your comment has been addressed. Would you mind re-reviewing? |
|
thank you, utACK a88640e |
a88640e Fix minimized window bug on Linux (Hennadii Stepanov) Pull request description: Fix #14591 On some Linux systems the minimized to the taskbar (iconified) main window cannot be restored properly using actions from the systray icon menu when `QSystemTrayIcon::contextMenu()` is a child of the main window. Tree-SHA512: 05c9f724fc2278d45dac6fe72b09859f12b5d71f54659bb779403c8cd81b55e610fb7b5aa912ac273d3cd19bf953b0405bbc6451feb00d1827c95dd9f0876aa4
Summary: a88640e123ca0c00d81719f9a009699c26e85b90 Fix minimized window bug on Linux (Hennadii Stepanov) Pull request description: Fix #14591 On some Linux systems the minimized to the taskbar (iconified) main window cannot be restored properly using actions from the systray icon menu when `QSystemTrayIcon::contextMenu()` is a child of the main window. --- Backport of Core [[bitcoin/bitcoin#14594 | PR14594]] Test Plan: ninja all check check-functional ./src/qt/bitcoin-qt -regtest make sure minimizing and restoring the window works fine Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8546
Summary: a88640e123ca0c00d81719f9a009699c26e85b90 Fix minimized window bug on Linux (Hennadii Stepanov) Pull request description: Fix #14591 On some Linux systems the minimized to the taskbar (iconified) main window cannot be restored properly using actions from the systray icon menu when `QSystemTrayIcon::contextMenu()` is a child of the main window. --- Backport of Core [[bitcoin/bitcoin#14594 | PR14594]] Test Plan: ninja all check check-functional ./src/qt/bitcoin-qt -regtest make sure minimizing and restoring the window works fine Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8546
a88640e Fix minimized window bug on Linux (Hennadii Stepanov) Pull request description: Fix bitcoin#14591 On some Linux systems the minimized to the taskbar (iconified) main window cannot be restored properly using actions from the systray icon menu when `QSystemTrayIcon::contextMenu()` is a child of the main window. Tree-SHA512: 05c9f724fc2278d45dac6fe72b09859f12b5d71f54659bb779403c8cd81b55e610fb7b5aa912ac273d3cd19bf953b0405bbc6451feb00d1827c95dd9f0876aa4
a88640e Fix minimized window bug on Linux (Hennadii Stepanov) Pull request description: Fix bitcoin#14591 On some Linux systems the minimized to the taskbar (iconified) main window cannot be restored properly using actions from the systray icon menu when `QSystemTrayIcon::contextMenu()` is a child of the main window. Tree-SHA512: 05c9f724fc2278d45dac6fe72b09859f12b5d71f54659bb779403c8cd81b55e610fb7b5aa912ac273d3cd19bf953b0405bbc6451feb00d1827c95dd9f0876aa4
a88640e Fix minimized window bug on Linux (Hennadii Stepanov) Pull request description: Fix bitcoin#14591 On some Linux systems the minimized to the taskbar (iconified) main window cannot be restored properly using actions from the systray icon menu when `QSystemTrayIcon::contextMenu()` is a child of the main window. Tree-SHA512: 05c9f724fc2278d45dac6fe72b09859f12b5d71f54659bb779403c8cd81b55e610fb7b5aa912ac273d3cd19bf953b0405bbc6451feb00d1827c95dd9f0876aa4
Fix #14591
On some Linux systems the minimized to the taskbar (iconified) main window cannot be restored properly using actions from the systray icon menu when
QSystemTrayIcon::contextMenu()is a child of the main window.