Qt: Fix restoration of minimized to tray window #14222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimizing the window with fMinimizeToTray=true actually do both showMinimized() and hide(). During restoration isMinimized() should be checked first. Otherwise, the restored window will be minimized.
Member
Contributor
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
Tested ACK f03c5c3 This successfully solves the "two step" show with the tray icon. Tested on all Ubuntu/macOS/Win. |
Member
|
Is this for backport? |
Contributor
|
Not sure this is worth back-porting... All UI-glitch-fixes have the risk to act differently in back ported versions. I would recommend to not back port it (if its not a clear bug that has been fixed). |
Contributor
|
Member
Author
|
@Sjors Do you mind reviewing this PR? |
Member
|
I can't find the "Minimize to the tray instead of the taskbar" option on macOS 10.14 with QT 5.11.2. |
Member
Author
|
bitcoin/src/qt/optionsdialog.cpp Lines 72 to 76 in f78558f |
Member
Member
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UX bug on Windows. Steps to reproduce (tested on Windows 10):
The normal size window is expected.
Actually the main window is restored minimized to the taskbar.
Rationale: minimizing the window with
fMinimizeToTray==trueactually do bothshowMinimized()andhide(). During restorationisMinimized()should be checked first. Otherwise, the restored window will be minimized.The logic is broken both on Windows and Linux, but on my Linux (Mint 19 + Cinnamon 3.8.9) the window manager renders the main window as if all is correct. Nevertheless, other Linux systems may be affected by this bug.
Ref: