[build] Actually remove ENABLE_WALLET #14208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Builds on #14204. Review that first. |
Member
|
utACK abdba5f59e348c7093bee2639ef6c2398e8d2f6c |
ryanofsky
reviewed
Sep 12, 2018
src/interfaces/node.cpp
Outdated
Contributor
There was a problem hiding this comment.
Can you drop g_wallet_init_interface references and throws in this file? They seem redundant if MakeWallet and GetWallets functions can throw now.
abdba5f to
3efef4b
Compare
Contributor
Author
|
#14204 is merged. I've rebased on master and addresed @ryanofsky's feedback: #14208 (comment) |
Member
|
utACK 3efef4b225308954b23a30c74d7781ba87a51b76 |
scravy
approved these changes
Sep 12, 2018
Contributor
scravy
left a comment
There was a problem hiding this comment.
utACK 3efef4b225308954b23a30c74d7781ba87a51b76
ryanofsky
reviewed
Sep 12, 2018
Contributor
ryanofsky
left a comment
There was a problem hiding this comment.
utACK 3efef4b225308954b23a30c74d7781ba87a51b76
src/interfaces/node.cpp
Outdated
Contributor
There was a problem hiding this comment.
2018-09-12 23:23:50 clang-tidy(pr=14208): interfaces/node.cpp:41:7: warning: declaration 'Wallet' is never referenced, but a declaration with the same name found in another namespace 'interfaces' [bugprone-forward-declaration-namespace]
2018-09-12 23:23:50 clang-tidy(pr=14208): interfaces/node.cpp:41:7: warning: no definition found for 'Wallet', but a definition with the same name 'Wallet' found in another namespace 'interfaces' [bugprone-forward-declaration-namespace]
Contributor
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Removes the final #ifdef ENABLE_WALLET from libbitcoin_server by calling g_wallet_init_interface.HasWalletSupport(), and redifining GetWallets() and MakeWallet() in dummywallet.cpp.
3efef4b to
e4ef4b4
Compare
Contributor
Author
|
I've addressed the comment in #14208 (comment) and force-pushed. |
Contributor
|
utACK e4ef4b4. |
laanwj
added a commit
that referenced
this pull request
Sep 13, 2018
e4ef4b4 [build] remove #ifdef ENABLE_WALLET from interfaces/node (John Newbery) Pull request description: Adds a couple of redefinitions to dummywallet.cpp. Tree-SHA512: d226bcccc46d089eac88beb54c31f6f18817682994b371f9793a5d28bec5d60dbdffacc8fc281807e25cc7f89da23e1f8f36fd99d12f8a40f77a972840e8c1b4
14 tasks
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 20, 2020
Summary: e4ef4b459548b4032b9da03b3103525f935acb82 [build] remove #ifdef ENABLE_WALLET from interfaces/node (John Newbery) Pull request description: Adds a couple of redefinitions to dummywallet.cpp. Tree-SHA512: d226bcccc46d089eac88beb54c31f6f18817682994b371f9793a5d28bec5d60dbdffacc8fc281807e25cc7f89da23e1f8f36fd99d12f8a40f77a972840e8c1b4 Backport of Core [[bitcoin/bitcoin#14208 | PR14208]] Test Plan: cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF .. ninja ninja check ninja check-functional ./bitcoind ./bitcoin-cli getnewaddress Verify rpc fails because there is no wallet. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5518
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
May 19, 2020
Summary: e4ef4b459548b4032b9da03b3103525f935acb82 [build] remove #ifdef ENABLE_WALLET from interfaces/node (John Newbery) Pull request description: Adds a couple of redefinitions to dummywallet.cpp. Tree-SHA512: d226bcccc46d089eac88beb54c31f6f18817682994b371f9793a5d28bec5d60dbdffacc8fc281807e25cc7f89da23e1f8f36fd99d12f8a40f77a972840e8c1b4 Backport of Core [[bitcoin/bitcoin#14208 | PR14208]] Test Plan: cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF .. ninja ninja check ninja check-functional ./bitcoind ./bitcoin-cli getnewaddress Verify rpc fails because there is no wallet. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5518
5tefan
added a commit
to 5tefan/dash
that referenced
this pull request
Aug 10, 2021
e4ef4b4 [build] remove #ifdef ENABLE_WALLET from interfaces/node (John Newbery) Pull request description: Adds a couple of redefinitions to dummywallet.cpp. Tree-SHA512: d226bcccc46d089eac88beb54c31f6f18817682994b371f9793a5d28bec5d60dbdffacc8fc281807e25cc7f89da23e1f8f36fd99d12f8a40f77a972840e8c1b4
5tefan
added a commit
to 5tefan/dash
that referenced
this pull request
Aug 12, 2021
e4ef4b4 [build] remove #ifdef ENABLE_WALLET from interfaces/node (John Newbery) Pull request description: Adds a couple of redefinitions to dummywallet.cpp. Tree-SHA512: d226bcccc46d089eac88beb54c31f6f18817682994b371f9793a5d28bec5d60dbdffacc8fc281807e25cc7f89da23e1f8f36fd99d12f8a40f77a972840e8c1b4 Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Aug 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a couple of redefinitions to dummywallet.cpp.