build: Move interfaces/* to libbitcoin_server #14204
Conversation
These are shared between bitcoind and bitcoin-qt. It is unnecessary for them to be linked against the other utilities.
|
Concept ACK |
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
How about multi-process? Are the interface headers enough for the wallet process? |
|
Great! tACK e0664f7 |
I'd say we cross that bridge when we have to. For now, this makes sense. And also in that case, another library might have to be defined that has compilation units shared between the wallet process producer/consumer. Even then these things don't belong in the generic |
👍 no sense in holding up obvious improvements now for something that may or may not come in the future. |
|
Yeap agree! utACK e0664f7. |
e0664f7 build: Move interfaces/* to libbitcoin_server (Wladimir J. van der Laan) Pull request description: Move interfaces/* from libbitcoin_util to libbitcoin_server. Usage of these is shared between `bitcoind` and `bitcoin-qt`. It is unnecessary for them to be linked against the other utilities. Also semantically they belong with the server/node, I think. Tree-SHA512: f82f3a95d362051c0eb8092520715f77c2c75409d41f9c0fab9a15445ea9e79a2a36b5d00b1f5be09b266584051934a32a8b9b28f783f4d7be78885b4a29a383
e0664f7 build: Move interfaces/* to libbitcoin_server (Wladimir J. van der Laan) Pull request description: Move interfaces/* from libbitcoin_util to libbitcoin_server. Usage of these is shared between `bitcoind` and `bitcoin-qt`. It is unnecessary for them to be linked against the other utilities. Also semantically they belong with the server/node, I think. Tree-SHA512: f82f3a95d362051c0eb8092520715f77c2c75409d41f9c0fab9a15445ea9e79a2a36b5d00b1f5be09b266584051934a32a8b9b28f783f4d7be78885b4a29a383
Move interfaces/* from libbitcoin_util to libbitcoin_server.
Usage of these is shared between
bitcoindandbitcoin-qt. It is unnecessary for them to be linked against the other utilities. Also semantically they belong with the server/node, I think.