User-friendly errors#12
Merged
bmpvieira merged 3 commits intobionode:masterfrom Sep 17, 2015
terfilip:errors
Merged
Conversation
Contributor
Author
|
@bmpvieira Do you want me to add do a test for the error handling? The error occurs when transform gets an empty object. I guess the testing could be done by mocking the ncbi url using nock or something, and send back an empty/invalid object, to trigger the error. |
Signed-off-by: Filip Ter <filip.ter@gmail.com>
Signed-off-by: Filip Ter <filip.ter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply will throw error in case an object from NCBI has undefined properties that are required by bionode. The message will mention this could be an NCBI problem, and show the URL of the request.
Test data was out of date and making travis CI fail for the current blonde-ncbi. I updated test/data.json to have current ncbi data and make tests pass. Some fetched with script here + manual changes such as replacing 'content' with '_'.