Bep029 motion dualtask#354
Merged
sappelhoff merged 25 commits intobids-standard:bep029_motionfrom Feb 11, 2023
Merged
Conversation
motion.json has author names in correct format channels.tsv type column has "confidence" renamed to "misc" events are trimmed
Authors, Funding, ReferenceAndLinks fields in dataset_description.json are now arrays. Removed wrongly added Authors field in motion.json and eeg.json files.
For brevity only include 5 participants in the example.
Multi run files were missing in the previous fix
* Removed patterns in bidsignore which do not correspond to actual files * Added ingored invalid file
One subject was missing from the last update
Again a subject was missing from last touchup
Member
okay, that's something we need to fix, can you put it on your to do list for the validator and write an issue on bids-validator? It's not a blocker for progressing, we can fix it anytime soon. |
sappelhoff
added a commit
that referenced
this pull request
Mar 15, 2023
* Bep029 motion - Example systemvalidation (#347) * .json nesting style change, latency channel added * Updated to adhere to spec change, minor corrections. Motion.json contains fields from deprecated coordsys. Other minor differences result from updated version of FT data2bids. * Each tracksys has own json and channels * .json and channels.tsv bug fix, trim events Removed undefined field ExternalSoftwareVersions from motion.json Replaced undfined type values in motion channels.tsv Trimmed events.tsv filed that were too large * motion.json has now doi and funding info Added values for doi and funding fields in motion.json * Undoing mistaken changes to motion.json By mistake I had changed motion.json not dataset_description.json. Now correcting that. * eeg.json wrong fields also removed from body session * [ADD] dataset for dual motion capture systems, no brain imaging * [FIX] remove example dataset from this branch * [ADD] motion systemvalidation dataset * [FIX] smaller comments by @sappelhoff --------- Co-authored-by: sjeung <seinjeung@gmail.com> * tmp: use motion branch for master validation to be reverted before merging! * [ADD] Motion (BEP029): example data set "dualtask" (#329) * Add dual task data set * Update motion.json and channels.tsv motion.json has author names in correct format channels.tsv type column has "confidence" renamed to "misc" events are trimmed * Undoing change by mistake and doing the actual fix Authors, Funding, ReferenceAndLinks fields in dataset_description.json are now arrays. Removed wrongly added Authors field in motion.json and eeg.json files. * Update names in channel count fields * Remove headers from motion.tsv * Cut down number of participants For brevity only include 5 participants in the example. * Rename channel count json fields Multi run files were missing in the previous fix * Do not escape slashes * Delete ._.DS_Store * Update .gitignore * Remove invalid component entry * Added dualwalking data set to the main README --------- Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * Remove old version of SR data set (#349) * [ENH] Re-add spot rotation data set (#350) * added two motion datasets spotrotation: physical and virtual motion tracking and simultaneous eeg recording dualtask: multiple marker from optical system and simultaneous eeg recording * adjusted names * add stand session * Update participants.tsv * corrected file hierarchy * add example dataset motion_dualsystem_validation Example dataset for the BEP029 was added which includes 2 synchronised data recordings of optical motion capture and inertial measurement units * updated motion dualsystem example dataset * New files added to motion_dualsystem dataset * updated spotrotation and dualtask * updated dataset desc and participant json * empty motion.tsv files and added scans.json * .json nesting style change and latency channels added * Overall update. Deprecated coordsys, single tracksys is presented as array. * [FIX] Updated motion_dualsystem_validation dataset according to new BEP029 dev * Separate json and channel files for different tracksys * Remove other motion data sets than spot-rotation * Channel type fix and json extra field removal * Remove headers, use quaternions * Channel types in .json count fields updated * Cut down number of participants For brevity only include 5 participants in the example. * Remove escaped slashes * Add quat_prefix to quat components And modify wrong entries for components (latency, yaw) * Create README.md * Update README.md * Add motion_spotrotation to main README --------- Co-authored-by: Soeren <65068522+sgrothk@users.noreply.github.com> Co-authored-by: Julius Welzel <julius.welzel@gmail.com> Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * fix README * motion_systemvalidation - update bidsignore * remove bidsignore entirely from systemvalidation * Bep029 motion dualtask (#354) * Add dual task data set * Update motion.json and channels.tsv motion.json has author names in correct format channels.tsv type column has "confidence" renamed to "misc" events are trimmed * Undoing change by mistake and doing the actual fix Authors, Funding, ReferenceAndLinks fields in dataset_description.json are now arrays. Removed wrongly added Authors field in motion.json and eeg.json files. * Update names in channel count fields * Remove headers from motion.tsv * Cut down number of participants For brevity only include 5 participants in the example. * Rename channel count json fields Multi run files were missing in the previous fix * Do not escape slashes * Delete ._.DS_Store * Update .gitignore * Remove invalid component entry * Added dualwalking data set to the main README * Bidsignore (#351) * Removed patterns in bidsignore which do not correspond to actual files * Added ingored invalid file * Update readme and license * Fix typo in readme * Remove headers from motion.tsv * Update json field name One subject was missing from the last update * Replace invalid compnent entry with n/a Again a subject was missing from last touchup * Compnent column entry for latency channel is n/a * Compnent column entry for latency channel is n/a * Remove undefined fields from json of sub20 --------- Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> Co-authored-by: Horea Christian <chr@chymera.eu> * [FIX] Fix column order in channels.tsv files (#358) * [FIX] reorder columns to match schema * add latest changes * fix dataset name in readme * Remove repeating entries in scans.tsv --------- Co-authored-by: Julius Welzel <julius.welzel@gmail.com> * table fences * [FIX] remove StartTime field from motion.json as in spec change (#359) * [FIX] reorder columns to match schema * add latest changes * fix dataset name in readme * Remove repeating entries in scans.tsv * StartTime is removed from spec --------- Co-authored-by: Julius Welzel <julius.welzel@gmail.com> * Update motion_dualtask/participants.json Include age range in "young" * Update motion_dualtask/participants.json Include age range in "old" * Switch back to master for ci now that validator merged. --------- Co-authored-by: jwelzel <52565341+JuliusWelzel@users.noreply.github.com> Co-authored-by: sjeung <seinjeung@gmail.com> Co-authored-by: Soeren <65068522+sgrothk@users.noreply.github.com> Co-authored-by: Julius Welzel <julius.welzel@gmail.com> Co-authored-by: Ross Blair <rosswilsonblair@gmail.com> Co-authored-by: Horea Christian <chr@chymera.eu> Co-authored-by: Julia Guiomar Niso Galán <guiomar.niso@ctb.upm.es>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the [issues] (#348 (review)) @sappelhoff pointed out regarding dual task data set.
Extra json fields removed : there was one participant whose json was not updated
README - added
undefined columns warning seems to not go away when the .tsv files have no headers
The warning comes from motion.tsv files not channels.tsv and the same goes true for spot rotation data set.
I tried the version of motion.tsv that actually has (data but not header) entries in columns but the warning persists.