Write crate docs for bevy_scene2 / BSN#23604
Write crate docs for bevy_scene2 / BSN#23604alice-i-cecile merged 11 commits intobevyengine:mainfrom
Conversation
|
@NicoZweifel, you're one of the most familiar with BSN currently; I would appreciate your review here as well. |
|
I’m currently off on holiday until Friday evening, but am happy to take a look at this then - if this is not immediately urgent! |
urben1680
left a comment
There was a problem hiding this comment.
I read that as someone who never touched scenes and even assets rarely. I skipped the BSN PR(s) because I was overwhelmed by it, lacking the prior experience with the matter. I guess that makes me an ideal person to review this. 🙃
All in all I found this very informative and questions I had in my head were all answered. I just wrote comments on things I did not fully understand so maybe these can be improved.
# Objective While writing docs in #23604, I was wondering if closures and comments worked, especially after @urben1680's review comments. It's not immediately obvious that they should, and it's easy to break macros and parsing. ## Solution Add some simple tests to verify that this does in fact work!
|
I've gotten quite a bit of feedback at this point (thanks y'all!). Merging; we can improve on this more in follow-up <3 |
I'll leave this here for future reference: To expand on what @jasmine-nominal said, I think it would be good if the examples focused on things that you can't do or are hard/inconvenient without bsn, e.g.:
I know it is hard to put these into simple examples/few words but I think this is where the high value is at. |
Objective
The existing crate docs merged in #23413 were minimalistic.
This is not ideal, as there's a ton of complex, interconnected features that are important to explain.
In particular, we want to explain how all of these types, traits and concepts relate to each other
and the broad picture of both "how should you use this crate" and "why does this even exist".
Crate docs are the ideal home for this.
Solution
Write 400 lines of crate docs. Easy.
I am still relatively new to BSN: I haven't had a chance to use it in my projects yet either! Please keep an eye out for both technical and conceptual errors.
Thankfully, the PR description from #23413 was extremely detailed, laying out the architectural context and broader patterns.
The docs on each item, the tests, and to a lesser extent the old design discussions #9538 and #14437 were also very useful.
Notable editorial choices
Important omissions and divergences from past discussions
GetTemplatewas renamed toFromTemplateConstructis nowTemplateandFromTemplate