Add more tests for bsn! macro features#23611
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Mar 31, 2026
Merged
Conversation
ChristopherBiscardi
approved these changes
Mar 31, 2026
Contributor
ChristopherBiscardi
left a comment
There was a problem hiding this comment.
Tests! yes! and they even pass! 😆
kfc35
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
While writing docs in #23604, I was wondering if closures and comments worked, especially after @urben1680's review comments.
It's not immediately obvious that they should, and it's easy to break macros and parsing.
Solution
Add some simple tests to verify that this does in fact work!